Ref T7094. This makes the underlying class take a $user parameter, and then the worker just hands it an omnipotent user. Said underyling class is the benefactor of a small re-factor, dropping one query per-use, though the single query that now remains is policy-based so maybe its a wash or even worse. Still, gotta love one less query.
Details
Details
- Reviewers
epriestley - Maniphest Tasks
- T7094: Clean up T603
- Commits
- Restricted Diffusion Commit
rP026e3794831f: Policy - do proper policy queries when updating owners packages in commit…
a little tricky to test so some extra thought instead
basic acceptance test with bin/repository reparse --change rValidHashHere -- it worked!
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Hypothetically, you can bin/repository reparse --change rXsomething to exercise this, although I'm not sure you'll hit anything interesting by doing that. Looks correct to me, though.