Page MenuHomePhabricator

Policy - do proper policy queries when updating owners packages in commit workers
ClosedPublic

Authored by btrahan on Feb 3 2015, 7:51 PM.
Tags
None
Referenced Files
F18081330: D11653.id28050.diff
Mon, Aug 4, 11:48 PM
F18035733: D11653.id.diff
Sun, Aug 3, 1:39 AM
F17971571: D11653.diff
Fri, Aug 1, 3:17 PM
F17838264: D11653.diff
Sat, Jul 26, 6:25 PM
F17838254: D11653.diff
Sat, Jul 26, 6:24 PM
F17838253: D11653.diff
Sat, Jul 26, 6:24 PM
F17827278: D11653.diff
Sat, Jul 26, 8:06 AM
F17827276: D11653.diff
Sat, Jul 26, 8:06 AM
Subscribers

Details

Summary

Ref T7094. This makes the underlying class take a $user parameter, and then the worker just hands it an omnipotent user. Said underyling class is the benefactor of a small re-factor, dropping one query per-use, though the single query that now remains is policy-based so maybe its a wash or even worse. Still, gotta love one less query.

Test Plan

a little tricky to test so some extra thought instead

basic acceptance test with bin/repository reparse --change rValidHashHere -- it worked!

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

btrahan retitled this revision from to Policy - do proper policy queries when updating owners packages in commit workers.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
epriestley edited edge metadata.

Hypothetically, you can bin/repository reparse --change rXsomething to exercise this, although I'm not sure you'll hit anything interesting by doing that. Looks correct to me, though.

This revision is now accepted and ready to land.Feb 3 2015, 7:54 PM
btrahan edited edge metadata.
This revision was automatically updated to reflect the committed changes.