Paths

Table of Contentst

Differential D11636

Fix printing with new scroll
ClosedPublic
Actions

Authored by chad on Feb 3 2015, 2:34 AM.

Details

Reviewers

epriestley

Maniphest Tasks

T7115: Unable to print any page

Commits

Restricted Diffusion Commit
rP9df4cb37d405: Fix printing with new scroll

Summary

Fixes T7115, at least for me. Unclear if this is the "correct" fix.

Test Plan

Try to print, get page.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chad updated this revision to Diff 28005.Feb 3 2015, 2:34 AM

chad retitled this revision from to Fix printing with new scroll.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

chad added a task: T7115: Unable to print any page.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptFeb 3 2015, 2:34 AM

Slightly better?

Use !print on these rules instead of @media print, so ?__print__=1 also activates these rules.

https://secure.phabricator.com/book/phabcontrib/article/css_coding_standards/#printable-rules

e.g.

!print .main-page-frame {
  ...
}

This revision now requires changes to proceed.Feb 3 2015, 2:39 AM

(I do think this is the correct fix, at least more or less.)

Oh let me try again, I mucked with printable at first, but couldn't find the magic sauce.

!print

Cool, thanks for fixing this!

This revision is now accepted and ready to land.Feb 3 2015, 2:44 AM

epriestley awarded a token.Feb 3 2015, 2:44 AM

Closed by commit rP9df4cb37d405: Fix printing with new scroll (authored by chad, committed by chad). · Explain WhyFeb 3 2015, 2:45 AM

This revision was automatically updated to reflect the committed changes.

I'm just here so I won't get fined.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

6 lines

webroot/

rsrc/

css/

application/

base/

standard-page-view.css

12 lines

Diff 28008

View Options

resources/celerity/map.php