Page MenuHomePhabricator

Fix printing with new scroll
ClosedPublic

Authored by chad on Feb 3 2015, 2:34 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Feb 2, 4:47 AM
Unknown Object (File)
Wed, Feb 1, 12:51 AM
Unknown Object (File)
Thu, Jan 26, 12:32 AM
Unknown Object (File)
Sat, Jan 21, 9:02 PM
Unknown Object (File)
Fri, Jan 13, 9:52 PM
Unknown Object (File)
Jan 4 2023, 12:06 PM
Unknown Object (File)
Dec 31 2022, 3:39 AM
Unknown Object (File)
Dec 23 2022, 5:39 AM
Subscribers
Tokens
"Mountain of Wealth" token, awarded by epriestley.

Details

Reviewers
epriestley
Maniphest Tasks
T7115: Unable to print any page
Commits
Restricted Diffusion Commit
rP9df4cb37d405: Fix printing with new scroll
Summary

Fixes T7115, at least for me. Unclear if this is the "correct" fix.

Test Plan

Try to print, get page.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad retitled this revision from to Fix printing with new scroll.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
epriestley edited edge metadata.

Use !print on these rules instead of @media print, so ?__print__=1 also activates these rules.

https://secure.phabricator.com/book/phabcontrib/article/css_coding_standards/#printable-rules

e.g.

!print .main-page-frame {
  ...
}
This revision now requires changes to proceed.Feb 3 2015, 2:39 AM

(I do think this is the correct fix, at least more or less.)

Oh let me try again, I mucked with printable at first, but couldn't find the magic sauce.

chad edited edge metadata.
  • !print
epriestley edited edge metadata.

Cool, thanks for fixing this!

This revision is now accepted and ready to land.Feb 3 2015, 2:44 AM
This revision was automatically updated to reflect the committed changes.

I'm just here so I won't get fined.