Aphlict - remove listeners when clients close the connection
ClosedPublic
Actions

Authored by • pmoreau on Feb 2 2015, 10:49 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T7110: Listeners are not removed when clients close the WebSocket connection

Commits

Restricted Diffusion Commit
rP4af1fd2a79bb: Aphlict - remove listeners when clients close the connection

Summary

Ref T7110. Listeners are now removed when clients close the connection to avoid stacking a never ending number of unused listeners.

Test Plan

Using wscat to connect to the Aphlict server; when closing the connection a 'Diconnected.' will appear in the logs and the number of active listeners is decreased by one.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• pmoreau updated this revision to Diff 28000.Feb 2 2015, 10:49 PM

• pmoreau retitled this revision from to Aphlict - remove listeners when clients close the connection.

• pmoreau updated this object.

• pmoreau edited the test plan for this revision. (Show Details)

• pmoreau added a reviewer: epriestley.

• pmoreau added a task: T7110: Listeners are not removed when clients close the WebSocket connection.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptFeb 2 2015, 10:49 PM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

Thanks!

This revision is now accepted and ready to land.Feb 2 2015, 10:56 PM

Closed by commit rP4af1fd2a79bb: Aphlict - remove listeners when clients close the connection (authored by • pmoreau, committed by epriestley). · Explain WhyFeb 2 2015, 10:57 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

support/

aphlict/

server/

lib/

AphlictClientServer.js

5 lines

Diff 28002

View Options

support/aphlict/server/lib/AphlictClientServer.js

Aphlict - remove listeners when clients close the connectionClosedPublicActions