Page MenuHomePhabricator

Policy - clean up access to user profile image uri
AbandonedPublic

Authored by btrahan on Feb 2 2015, 9:58 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 16 2024, 8:16 PM
Unknown Object (File)
Jan 30 2024, 2:41 AM
Unknown Object (File)
Jan 20 2024, 5:40 PM
Unknown Object (File)
Jan 17 2024, 7:26 PM
Unknown Object (File)
Jan 16 2024, 8:51 PM
Unknown Object (File)
Jan 7 2024, 4:26 PM
Unknown Object (File)
Jan 3 2024, 7:08 PM
Unknown Object (File)
Dec 30 2023, 5:47 PM
Subscribers

Details

Reviewers
epriestley
Maniphest Tasks
T7094: Clean up T603
Summary

Ref T7094. We already had and were mostly using "needProfileImage" on the people query class. Only real trick in this diff is deleting a conduit end point that has been marked deprecated for the better part of 3 years.

Also includes a small bonus lint fix by adding the $for_app parameter to a child class so as to be consistent with the parent.

Test Plan

clicked around the people action and profiles and calendars loaded nicely.

Diff Detail

Repository
rP Phabricator
Branch
T7094_8
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 4256
Build 4269: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan retitled this revision from to Policy - clean up access to user profile image uri.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.