Differential D11589

Policy - lock down file loading in mail reply handler path
ClosedPublic
Actions

Authored by btrahan on Jan 30 2015, 11:14 PM.

Details

Reviewers

epriestley

Maniphest Tasks

T7094: Clean up T603

Commits

Restricted Diffusion Commit
rP388d1ff7bd92: Policy - lock down file loading in mail reply handler path

Summary

Ref T7094. This one is really straight-forward since $this->actor is always populated and the right thing to do here.

Test Plan

used the ole thinking noodle since testing email w/ attachments is really hard

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

btrahan updated this revision to Diff 27883.Jan 30 2015, 11:14 PM

btrahan added a task: T7094: Clean up T603.

btrahan retitled this revision from to Policy - lock down file loading in mail reply handler path.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added a reviewer: epriestley.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptJan 30 2015, 11:14 PM

epriestley accepted this revision.Jan 31 2015, 2:26 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jan 31 2015, 2:26 PM

Closed by commit rP388d1ff7bd92: Policy - lock down file loading in mail reply handler path (authored by btrahan, committed by btrahan). · Explain WhyFeb 2 2015, 10:02 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

metamta/

replyhandler/

PhabricatorMailReplyHandler.php

7 lines

Diff 27991

View Options

src/applications/metamta/replyhandler/PhabricatorMailReplyHandler.php

Policy - lock down file loading in mail reply handler pathClosedPublicActions