Page MenuHomePhabricator
Differential D11586

Policy - remove loadRepository() method from ArcanistProjects
ClosedPublic
Actions

Authored by btrahan on Jan 30 2015, 11:04 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, May 30, 8:02 AM
Unknown Object (File)
Thu, May 29, 8:39 PM
Unknown Object (File)
Thu, May 29, 6:20 AM
Unknown Object (File)
Wed, May 28, 9:05 PM
Unknown Object (File)
Apr 22 2025, 6:16 PM
Unknown Object (File)
Apr 9 2025, 1:10 AM
Unknown Object (File)
Apr 3 2025, 12:57 PM
Unknown Object (File)
Mar 30 2025, 9:28 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T7094: Clean up T603
Commits
Restricted Diffusion Commit
rPf58dce681905: Policy - remove loadRepository() method from ArcanistProjects
Summary

Ref T7094. This loadRepository() method bypassed policy unnecessarily. kill it.

Test Plan

basically un-tested since arcanist projects are deprecated and the main callsites were in releeph. conduit end point still works though!

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

btrahan updated this revision to Diff 27880.Jan 30 2015, 11:04 PM
btrahan added a task: T7094: Clean up T603.
btrahan retitled this revision from to Policy - remove loadRepository() method from ArcanistProjects.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptJan 30 2015, 11:04 PM
epriestley accepted this revision.Jan 31 2015, 2:24 PM
epriestley edited edge metadata.

yeahhhhh

This revision is now accepted and ready to land.Jan 31 2015, 2:24 PM
Closed by commit rPf58dce681905: Policy - remove loadRepository() method from ArcanistProjects (authored by btrahan, committed by btrahan). · Explain WhyFeb 2 2015, 9:58 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
arcanist/
conduit/
8 lines
releeph/
controller/
branch/
4 lines
product/
9 lines
2 lines
view/
branch/
21 lines
repository/
storage/
8 lines

Diff 27989

View Options

src/applications/arcanist/conduit/ArcanistProjectInfoConduitAPIMethod.php

Loading...
View Options

src/applications/releeph/controller/branch/ReleephBranchNamePreviewController.php

Loading...
View Options

src/applications/releeph/controller/product/ReleephProductCreateController.php

Loading...
View Options

src/applications/releeph/controller/product/ReleephProductEditController.php

Loading...
View Options

src/applications/releeph/view/branch/ReleephBranchTemplate.php

Loading...
View Options

src/applications/repository/storage/PhabricatorRepositoryArcanistProject.php

Loading...
Phabricator · Built by Phacility