Differential D11585

Policy - lock down loadCommit() from DiffusionRequest objects
ClosedPublic
Actions

Authored by btrahan on Jan 30 2015, 10:47 PM.

Details

Reviewers

epriestley

Maniphest Tasks

T7094: Clean up T603

Commits

Restricted Diffusion Commit
rP8573d5b0c1a3: Policy - lock down loadCommit() from DiffusionRequest objects

Summary

Ref T7094. The class DiffusionRequest has other public methods which use getUser() in an unguarded way. Code inspection of the call sites for loadCommit() also leads me to believe the $user is properly set.

Test Plan

clicked around diffusion a bunch and everything seemed to work okay. (happy to test any particular esoteric endpoints that come to mind)

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

btrahan updated this revision to Diff 27879.Jan 30 2015, 10:47 PM

btrahan added a task: T7094: Clean up T603.

btrahan retitled this revision from to Policy - lock down loadCommit() from DiffusionRequest objects.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added a reviewer: epriestley.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptJan 30 2015, 10:47 PM

I suspect we're consistent on providing a user now.

This revision is now accepted and ready to land.Jan 31 2015, 2:24 PM

Closed by commit rP8573d5b0c1a3: Policy - lock down loadCommit() from DiffusionRequest objects (authored by btrahan, committed by btrahan). · Explain WhyFeb 1 2015, 5:33 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

request/

DiffusionRequest.php

11 lines

Diff 27913

View Options

src/applications/diffusion/request/DiffusionRequest.php

Policy - lock down loadCommit() from DiffusionRequest objectsClosedPublicActions