Page MenuHomePhabricator

Policy - lock down loadCommit() from DiffusionRequest objects
ClosedPublic

Authored by btrahan on Jan 30 2015, 10:47 PM.

Details

Summary

Ref T7094. The class DiffusionRequest has other public methods which use getUser() in an unguarded way. Code inspection of the call sites for loadCommit() also leads me to believe the $user is properly set.

Test Plan

clicked around diffusion a bunch and everything seemed to work okay. (happy to test any particular esoteric endpoints that come to mind)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

btrahan retitled this revision from to Policy - lock down loadCommit() from DiffusionRequest objects.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
epriestley edited edge metadata.

I suspect we're consistent on providing a user now.

This revision is now accepted and ready to land.Jan 31 2015, 2:24 PM
This revision was automatically updated to reflect the committed changes.