Page MenuHomePhabricator
Differential D11584

Policy - lock down DiffusionSymbolQuery repo-loading code
ClosedPublic
Actions

Authored by btrahan on Jan 30 2015, 10:35 PM.
Tags
None
Referenced Files
F15449377: D11584.id.diff
Fri, Mar 28, 9:49 AM
F15444822: D11584.diff
Thu, Mar 27, 11:29 AM
F15438245: D11584.id.diff
Tue, Mar 25, 11:50 PM
F15437835: D11584.id27878.diff
Tue, Mar 25, 9:45 PM
F15421830: D11584.id.diff
Sat, Mar 22, 2:27 AM
F15421433: D11584.id27901.diff
Fri, Mar 21, 11:45 PM
F15402406: D11584.id27878.diff
Mon, Mar 17, 10:21 PM
F15380205: D11584.id27878.diff
Fri, Mar 14, 2:00 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T7094: Clean up T603
Commits
Restricted Diffusion Commit
rPe1dcbc43866a: Policy - lock down DiffusionSymbolQuery repo-loading code
Summary

Ref T7094.

Test Plan

couldn't really test this - how does one get symbols going nowadays given they are acanist project based?

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

btrahan updated this revision to Diff 27878.Jan 30 2015, 10:35 PM
btrahan added a task: T7094: Clean up T603.
btrahan retitled this revision from to Policy - lock down DiffusionSymbolQuery repo-loading code.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptJan 30 2015, 10:35 PM
epriestley accepted this revision.Jan 31 2015, 2:23 PM
epriestley edited edge metadata.

Not too worried about this.

This revision is now accepted and ready to land.Jan 31 2015, 2:23 PM
Closed by commit rPe1dcbc43866a: Policy - lock down DiffusionSymbolQuery repo-loading code (authored by btrahan, committed by btrahan). · Explain WhyFeb 1 2015, 2:36 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
diffusion/
conduit/
3 lines
controller/
5 lines
query/
23 lines
typeahead/
1 line

Diff 27901

View Options

src/applications/diffusion/conduit/DiffusionFindSymbolsConduitAPIMethod.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionSymbolController.php

Loading...
View Options

src/applications/diffusion/query/DiffusionSymbolQuery.php

Loading...
View Options

src/applications/diffusion/typeahead/DiffusionSymbolDatasource.php

Loading...
Phabricator · Built by Phacility