Page MenuHomePhabricator
Differential D11558

Raise a setup warning for an unparseable VCS binary version
ClosedPublic
Actions

Authored by epriestley on Jan 29 2015, 2:33 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 27, 4:24 AM
Unknown Object (File)
Sat, Dec 21, 5:15 PM
Unknown Object (File)
Mon, Dec 9, 3:44 PM
Unknown Object (File)
Fri, Dec 6, 12:30 PM
Unknown Object (File)
Fri, Dec 6, 10:43 AM
Unknown Object (File)
Fri, Dec 6, 2:46 AM
Unknown Object (File)
Thu, Dec 5, 4:03 AM
Unknown Object (File)
Thu, Dec 5, 3:31 AM
View All Files
Subscribers
epriestley
Tokens
"Piece of Eight" token, awarded by btrahan.

Details

Reviewers
btrahan
Commits
Restricted Diffusion Commit
rPc2efa9065ca9: Raise a setup warning for an unparseable VCS binary version
Summary

Hit this locally, with an error like:

Version <empty string> is older than 1.9, the minimum supported version.

(Where <empty string> was just the empty string, not literally the text <empty string>.)

Be more careful about parsing versions, and parse the newer string.

Test Plan

Got "unknown version" with intentionally-broken test data, then clean readout.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 27812.Jan 29 2015, 2:33 PM
epriestley retitled this revision from to Raise a setup warning for an unparseable VCS binary version.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
Herald added a subscriber: epriestley. · View Herald TranscriptJan 29 2015, 2:33 PM
btrahan accepted this revision.Jan 29 2015, 5:02 PM
btrahan edited edge metadata.
btrahan added inline comments.
src/applications/config/check/PhabricatorBinariesSetupCheck.php
208–209

maybe link "report the issue" to the reporting issues doc

This revision is now accepted and ready to land.Jan 29 2015, 5:02 PM
epriestley added a comment.Jan 29 2015, 10:04 PM

I'm just going to leave it unlinked because adding inline links here interacts badly with translations, and turning this into Remarkup is involved and questionable.

Well, maybe there should be an ->addLink() thing. I could just do that.

epriestley updated this revision to Diff 27838.Jan 29 2015, 10:18 PM
epriestley edited edge metadata.
  • Add an addLink() method for setup issues.
  • Use it to link to the bug reporting guide.
btrahan awarded a token.Jan 29 2015, 10:19 PM
Closed by commit rPc2efa9065ca9: Raise a setup warning for an unparseable VCS binary version (authored by epriestley, committed by epriestley). · Explain WhyJan 29 2015, 10:28 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
config/
check/
82 lines
issue/
14 lines
view/
38 lines
infrastructure/
internationalization/
translation/
5 lines

Diff 27840

View Options

src/applications/config/check/PhabricatorBinariesSetupCheck.php

Loading...
View Options

src/applications/config/issue/PhabricatorSetupIssue.php

Loading...
View Options

src/applications/config/view/PhabricatorSetupIssueView.php

Loading...
View Options

src/infrastructure/internationalization/translation/PhabricatorBaseEnglishTranslation.php

Loading...
Phabricator · Built by Phacility