Use idx() to access resource attributes in case it's not set on the resource
AbandonedPublic
Actions

Authored by hach-que on Jan 28 2015, 1:11 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Summary

Manually created resources might not have attributes set against them. Ensure that we don't error due to a missing key when retrieving custom attributes on resources.

Depends on all the other Drydock patches first.

Test Plan

Noticed this when using a resource made with create-resource and attempting to allocate against it.

Diff Detail

Repository

rP Phabricator

Branch

attributes-fix

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 4102
Build 4115: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

hach-que updated this revision to Diff 27744.Jan 28 2015, 1:11 AM

hach-que retitled this revision from to Use idx() to access resource attributes in case it's not set on the resource.

hach-que updated this object.

hach-que edited the test plan for this revision. (Show Details)

hach-que added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 28 2015, 1:11 AM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

epriestley accepted this revision.Jan 28 2015, 7:11 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jan 28 2015, 7:11 PM

Superseded by D13984.

Revision Contents
Changeset List

Path

Size

src/

applications/

harbormaster/

step/

HarbormasterLeaseHostBuildStepImplementation.php

2 lines

Diff 27744

View Options

src/applications/harbormaster/step/HarbormasterLeaseHostBuildStepImplementation.php

Use idx() to access resource attributes in case it's not set on the resourceAbandonedPublicActions