Differential D11524

Give Maniphest a title glyph
ClosedPublic
Actions

Authored by epriestley on Jan 27 2015, 3:46 PM.

Tags

None

Referenced Files

	F14059792: D11524.diff
	Sun, Nov 17, 9:41 PM

	F14050796: D11524.diff
	Thu, Nov 14, 8:44 PM

	F14033579: D11524.diff
	Sat, Nov 9, 6:24 PM

	F14021959: D11524.diff
	Wed, Nov 6, 2:10 PM

	F14009639: D11524.diff
	Wed, Oct 30, 9:53 PM

	F14002083: D11524.id.diff
	Fri, Oct 25, 2:56 PM

	F13966266: D11524.id27712.diff
	Oct 16 2024, 7:17 AM

	Unknown Object (File)
	Oct 7 2024, 3:23 PM

Subscribers

Details

Reviewers

Maniphest Tasks

T7055: ApplicationSearch page titles have slightly too little context after removing "Query:"?

Commits

Restricted Diffusion Commit
rP5b6b2ee8505f: Give Maniphest a title glyph

Summary

Ref T7055. Apparently we just never had one? I feel like I'm crazy. But I can't find any trace in the logs.

I'm actually not 100% sold on this being better because it's a color glyph on OSX and those feel a little out of place / tacky to me compared to the black-and-white ones. So I'd be fine with just leaving it off, too. Clearly not important if no one noticed it until I caught it in T7055.

Test Plan

Screen_Shot_2015-01-27_at_7.45.41_AM.png (33×120 px, 6 KB)

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 27712.Jan 27 2015, 3:46 PM

epriestley retitled this revision from to Give Maniphest a title glyph.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T7055: ApplicationSearch page titles have slightly too little context after removing "Query:"?.

Herald added a subscriber: epriestley. · View Herald TranscriptJan 27 2015, 3:46 PM

chad accepted this revision.Jan 27 2015, 4:25 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Jan 27 2015, 4:25 PM

Closed by commit rP5b6b2ee8505f: Give Maniphest a title glyph (authored by epriestley, committed by epriestley). · Explain WhyJan 27 2015, 10:49 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

maniphest/

application/

PhabricatorManiphestApplication.php

4 lines

Diff 27731

src/applications/maniphest/application/PhabricatorManiphestApplication.php

Loading...