Page MenuHomePhabricator

Promote instance identity to the upstream and pass it to commit hooks
ClosedPublic

Authored by epriestley on Jan 25 2015, 5:49 PM.
Tags
None
Referenced Files
F14390193: D11495.diff
Sat, Dec 21, 6:14 PM
Unknown Object (File)
Tue, Dec 17, 3:42 AM
Unknown Object (File)
Tue, Dec 17, 2:50 AM
Unknown Object (File)
Sun, Dec 15, 3:58 AM
Unknown Object (File)
Sat, Dec 14, 6:04 PM
Unknown Object (File)
Sat, Dec 14, 6:02 PM
Unknown Object (File)
Tue, Dec 3, 10:12 PM
Unknown Object (File)
Wed, Nov 27, 6:37 PM
Subscribers

Details

Summary

Fixes T7019. In a cluster environment, pushes currently fail because the commit hook can't identify the instance.

For web processes, the hostname identifies the instance -- but we don't have a hostname in the hook.

For CLI processes, the environment identifies the instance -- but we don't have an environment in the hook under SVN.

Promote the instance identifier into the upstream and pack/unpack it explicitly for hooks. This is probably not useful for anyone but us, but the amount of special-purpose code we're introducing is very small.

I poked at trying to do this in a more general way, but:

  • We MUST know this BEFORE we run code, so the normal subclassing stuff is useless.
  • I couldn't come up with any other parameter which might ever be useful to pass in.
Test Plan

Used git push to push code through proxied HTTP, got a clean push.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Promote instance identity to the upstream and pass it to commit hooks.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Jan 27 2015, 10:23 PM
This revision was automatically updated to reflect the committed changes.