Differential D11491

In Diffusion, split service URI resolution from conduit client construction
ClosedPublic
Actions

Authored by epriestley on Jan 25 2015, 2:54 PM.

Details

Reviewers

btrahan

Maniphest Tasks

Restricted Maniphest Task
T7019: Proxy HTTP VCS traffic

Commits

Restricted Diffusion Commit
rPac41db402aa7: In Diffusion, split service URI resolution from conduit client construction

Summary

Ref T7019. Ref T7034. In both proxying cases, we want to proxy the request but can not do so over Conduit.

Split the URI resolution apart from Conduit client construction so we can just pull an SSH or HTTP/S URI out of the repository without getting an entire Conduit client.

Test Plan

Browsed around a service-hosted repository. This diff has no behavioral changes.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 27640.Jan 25 2015, 2:54 PM

epriestley retitled this revision from to In Diffusion, split service URI resolution from conduit client construction.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added tasks: T7019: Proxy HTTP VCS traffic, Restricted Maniphest Task.

Herald added a subscriber: epriestley. · View Herald TranscriptJan 25 2015, 2:54 PM

btrahan accepted this revision.Jan 27 2015, 10:07 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Jan 27 2015, 10:07 PM

Closed by commit rPac41db402aa7: In Diffusion, split service URI resolution from conduit client construction (authored by epriestley, committed by epriestley). · Explain WhyJan 27 2015, 10:50 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

repository/

storage/

PhabricatorRepository.php

122 lines

Diff 27733

View Options

src/applications/repository/storage/PhabricatorRepository.php

In Diffusion, split service URI resolution from conduit client constructionClosedPublicActions