Page MenuHomePhabricator

Differential - return a better response for validation error cases
ClosedPublic

Authored by btrahan on Jan 20 2015, 9:40 PM.
Tags
None
Referenced Files
F15388075: D11448.id27520.diff
Sat, Mar 15, 3:16 AM
F15383057: D11448.diff
Fri, Mar 14, 3:24 PM
F15373210: D11448.diff
Wed, Mar 12, 3:02 PM
F15337469: D11448.diff
Sun, Mar 9, 6:00 AM
Unknown Object (File)
Fri, Feb 28, 4:13 AM
Unknown Object (File)
Feb 7 2025, 12:36 AM
Unknown Object (File)
Feb 4 2025, 2:07 AM
Unknown Object (File)
Feb 4 2025, 2:07 AM
Subscribers
Tokens
"Grey Medal" token, awarded by epriestley.

Details

Summary

Fixes T6989. Basically return a nice dialogue like we do for "NoEffect" transactions. This is a little prettier than the other dialogue was. Also, stop adding TYPE_EDGE as a transaction type as we end up having it 2x, which then makes the error get validated 2x.

Test Plan

tried to add myself as a reviewer and got a nice error message.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

btrahan retitled this revision from to Differential - return a better response for validation error cases.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added reviewers: epriestley, chad.
This revision is now accepted and ready to land.Jan 20 2015, 9:58 PM
This revision was automatically updated to reflect the committed changes.