Page MenuHomePhabricator

Differential - return a better response for validation error cases
ClosedPublic

Authored by btrahan on Jan 20 2015, 9:40 PM.
Tags
None
Referenced Files
F14033122: D11448.diff
Sat, Nov 9, 4:48 PM
F14018892: D11448.diff
Tue, Nov 5, 8:27 PM
F13985971: D11448.id27520.diff
Sun, Oct 20, 11:52 PM
F13976316: D11448.id27520.diff
Fri, Oct 18, 1:44 PM
Unknown Object (File)
Sep 18 2024, 3:29 PM
Unknown Object (File)
Sep 9 2024, 5:58 PM
Unknown Object (File)
Sep 3 2024, 3:26 PM
Unknown Object (File)
Sep 3 2024, 4:49 AM
Subscribers
Tokens
"Grey Medal" token, awarded by epriestley.

Details

Summary

Fixes T6989. Basically return a nice dialogue like we do for "NoEffect" transactions. This is a little prettier than the other dialogue was. Also, stop adding TYPE_EDGE as a transaction type as we end up having it 2x, which then makes the error get validated 2x.

Test Plan

tried to add myself as a reviewer and got a nice error message.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

btrahan retitled this revision from to Differential - return a better response for validation error cases.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added reviewers: epriestley, chad.
This revision is now accepted and ready to land.Jan 20 2015, 9:58 PM
This revision was automatically updated to reflect the committed changes.