Page MenuHomePhabricator

Differential - return a better response for validation error cases
ClosedPublic

Authored by btrahan on Jan 20 2015, 9:40 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jan 28, 11:48 PM
Unknown Object (File)
Sat, Jan 11, 10:40 PM
Unknown Object (File)
Dec 27 2024, 1:43 PM
Unknown Object (File)
Dec 24 2024, 6:30 PM
Unknown Object (File)
Dec 24 2024, 3:03 AM
Unknown Object (File)
Dec 12 2024, 6:13 PM
Unknown Object (File)
Dec 12 2024, 10:49 AM
Unknown Object (File)
Dec 4 2024, 10:31 AM
Subscribers
Tokens
"Grey Medal" token, awarded by epriestley.

Details

Summary

Fixes T6989. Basically return a nice dialogue like we do for "NoEffect" transactions. This is a little prettier than the other dialogue was. Also, stop adding TYPE_EDGE as a transaction type as we end up having it 2x, which then makes the error get validated 2x.

Test Plan

tried to add myself as a reviewer and got a nice error message.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

btrahan retitled this revision from to Differential - return a better response for validation error cases.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added reviewers: epriestley, chad.
This revision is now accepted and ready to land.Jan 20 2015, 9:58 PM
This revision was automatically updated to reflect the committed changes.