Page MenuHomePhabricator

Differential - return a better response for validation error cases
ClosedPublic

Authored by btrahan on Jan 20 2015, 9:40 PM.
Tags
None
Referenced Files
F18629162: D11448.id27521.diff
Sep 16 2025, 8:07 AM
F18597078: D11448.diff
Sep 13 2025, 2:05 AM
F18597075: D11448.diff
Sep 13 2025, 2:04 AM
F18593960: D11448.id27520.diff
Sep 12 2025, 4:33 PM
F18591362: D11448.id27520.diff
Sep 12 2025, 9:02 AM
F18591005: D11448.diff
Sep 12 2025, 7:56 AM
F18543019: D11448.diff
Sep 7 2025, 11:23 PM
F18088082: D11448.id27520.diff
Aug 6 2025, 6:46 AM
Subscribers
Tokens
"Grey Medal" token, awarded by epriestley.

Details

Summary

Fixes T6989. Basically return a nice dialogue like we do for "NoEffect" transactions. This is a little prettier than the other dialogue was. Also, stop adding TYPE_EDGE as a transaction type as we end up having it 2x, which then makes the error get validated 2x.

Test Plan

tried to add myself as a reviewer and got a nice error message.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

btrahan retitled this revision from to Differential - return a better response for validation error cases.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added reviewers: epriestley, chad.
This revision is now accepted and ready to land.Jan 20 2015, 9:58 PM
This revision was automatically updated to reflect the committed changes.