Page MenuHomePhabricator

Recover more cleanly from worker tasks with unconstructable classes
ClosedPublic

Authored by epriestley on Jan 15 2015, 3:05 PM.
Tags
None
Referenced Files
F13776891: D11413.diff
Tue, Sep 10, 9:09 PM
Unknown Object (File)
Tue, Sep 3, 1:40 AM
Unknown Object (File)
Sun, Sep 1, 2:37 AM
Unknown Object (File)
Thu, Aug 29, 6:44 AM
Unknown Object (File)
Thu, Aug 15, 8:23 PM
Unknown Object (File)
Aug 12 2024, 1:18 AM
Unknown Object (File)
Aug 7 2024, 3:49 PM
Unknown Object (File)
Aug 3 2024, 1:01 AM
Subscribers

Details

Summary

This is unusual, but if getWorkerInstance() throws we end up with an undefined $worker when recovering from the exception.

Instead, handle this case slightly more gracefully.

The easiest way to hit this is to schedule a task for a worker that doesn't exist (or remove an existing worker, which is what I did to hit it).

Test Plan

Saw a more graceful error recovery; ran some normal successful tasks out of the queue.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Recover more cleanly from worker tasks with unconstructable classes.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Jan 15 2015, 6:29 PM
This revision was automatically updated to reflect the committed changes.