Check policy.locked slightly sooner in PhabricatorApplication
ClosedPublic
Actions

Authored by epriestley on Jan 13 2015, 8:07 PM.

Tags

None

Referenced Files

	F19122354: D11374.id27324.diff
	Tue, Dec 9, 11:23 PM

	F18976216: D11374.diff
	Sun, Nov 16, 1:05 PM

	F18976198: D11374.diff
	Sun, Nov 16, 1:02 PM

	F18906560: D11374.id.diff
	Nov 8 2025, 7:03 PM

	F18870654: D11374.diff
	Nov 4 2025, 6:15 PM

	F18809059: D11374.id.diff
	Oct 19 2025, 10:56 AM

	F18799277: D11374.diff
	Oct 17 2025, 12:59 PM

	F18799272: D11374.diff
	Oct 17 2025, 12:58 PM

View All Files

Subscribers

epriestley

Details

Reviewers

btrahan

Commits

Restricted Diffusion Commit
rPad9af106ee08: Check policy.locked slightly sooner in PhabricatorApplication

Summary

We could still miss this if the policy had never been customized and we returned early after one of the other checks.

Test Plan

Works great on instances now.

Screen_Shot_2015-01-13_at_12.06.12_PM.png (1×1 px, 173 KB)

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 27324.Jan 13 2015, 8:07 PM

epriestley retitled this revision from to Check policy.locked slightly sooner in PhabricatorApplication.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

Herald added a subscriber: epriestley. · View Herald TranscriptJan 13 2015, 8:07 PM

btrahan accepted this revision.Jan 13 2015, 8:33 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Jan 13 2015, 8:33 PM

Closed by commit rPad9af106ee08: Check policy.locked slightly sooner in PhabricatorApplication (authored by epriestley, committed by epriestley). · Explain WhyJan 13 2015, 8:40 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

base/

PhabricatorApplication.php

10 lines

Diff 27327

View Options

src/applications/base/PhabricatorApplication.php

Check policy.locked slightly sooner in PhabricatorApplicationClosedPublicActions