Page MenuHomePhabricator

Followup from D11358#106424 and make policy.locked fully work
ClosedPublic

Authored by btrahan on Jan 13 2015, 7:55 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 22, 8:20 AM
Unknown Object (File)
Mon, Nov 18, 7:24 AM
Unknown Object (File)
Wed, Nov 13, 11:35 PM
Unknown Object (File)
Sun, Nov 10, 9:21 AM
Unknown Object (File)
Wed, Nov 6, 5:00 AM
Unknown Object (File)
Mon, Nov 4, 8:08 AM
Unknown Object (File)
Mon, Nov 4, 8:08 AM
Unknown Object (File)
Oct 9 2024, 2:23 PM
Subscribers

Details

Summary

Fast commit. Also forgot to make the config override the existing policy. I *think* this is the right spot and we're good? Ref T6947.

Test Plan

viewed the application settings page for people application and saw the correct overrode setting.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

btrahan retitled this revision from to Followup from D11358#106424 and make policy.locked fully work.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
epriestley edited edge metadata.

Possibly-better location for the override inline?

src/applications/policy/query/PhabricatorPolicyQuery.php
26–33 ↗(On Diff #27313)

Hmm, I think I'd try putting this in PhabricatorApplication->getCustomPolicySetting() instead.

This revision is now accepted and ready to land.Jan 13 2015, 7:58 PM
btrahan edited edge metadata.

put the override in the better spot

This revision was automatically updated to reflect the committed changes.