Differential D11348

Diffusion - missed a "dont load diffusion request" in the code serving pathway
ClosedPublic
Actions

Authored by btrahan on Jan 12 2015, 4:50 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Sep 29, 7:39 AM

	Unknown Object (File)
	Thu, Sep 12, 6:32 PM

	Unknown Object (File)
	Wed, Sep 11, 9:59 AM

	Unknown Object (File)
	Tue, Sep 10, 5:53 AM

	Unknown Object (File)
	Tue, Sep 10, 5:53 AM

	Unknown Object (File)
	Tue, Sep 10, 5:53 AM

	Unknown Object (File)
	Mon, Sep 9, 2:03 AM

	Unknown Object (File)
	Wed, Sep 4, 5:45 PM

Subscribers

Details

Reviewers

epriestley
chad

Maniphest Tasks

T6939: InvalidArgumentException error when calling: GET /diffusion/REPO/repo.git/info/refs?service=git-upload-pack HTTP/1.1

Commits

Restricted Diffusion Commit
rP2d904dfddf44: Diffusion - missed a "dont load diffusion request" in the code serving pathway

Summary

Fixes T6939.

Test Plan

From the task, visited a URI like http://code.example.com/diffusion/REPO/repo.git/info/refs?service=git-upload-pack. Before the patch, I got an error and post patch I get a nice login prompt to provide credentials to the repository, as expected based on my confguration

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

btrahan updated this revision to Diff 27258.Jan 12 2015, 4:50 PM

btrahan added a task: T6939: InvalidArgumentException error when calling: GET /diffusion/REPO/repo.git/info/refs?service=git-upload-pack HTTP/1.1.

btrahan retitled this revision from to Diffusion - missed a "dont load diffusion request" in the code serving pathway.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added reviewers: epriestley, chad.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptJan 12 2015, 4:50 PM

epriestley accepted this revision.Jan 12 2015, 4:50 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jan 12 2015, 4:50 PM

Closed by commit rP2d904dfddf44: Diffusion - missed a "dont load diffusion request" in the code serving pathway (authored by btrahan, committed by btrahan). · Explain WhyJan 12 2015, 4:50 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

controller/

DiffusionServeController.php

4 lines

Diff 27259

src/applications/diffusion/controller/DiffusionServeController.php

Loading...