Page MenuHomePhabricator

Make test for setting "next" cookie more general
ClosedPublic

Authored by epriestley on Jan 9 2015, 12:24 AM.
Tags
None
Referenced Files
F14082113: D11292.id27142.diff
Fri, Nov 22, 10:48 PM
F14082111: D11292.id.diff
Fri, Nov 22, 10:48 PM
F14082109: D11292.id27130.diff
Fri, Nov 22, 10:48 PM
F14081969: D11292.diff
Fri, Nov 22, 10:23 PM
Unknown Object (File)
Wed, Nov 13, 1:06 AM
Unknown Object (File)
Sun, Nov 10, 4:01 PM
Unknown Object (File)
Tue, Nov 5, 9:37 PM
Unknown Object (File)
Oct 16 2024, 6:58 AM

Details

Summary

Ref T6870. Since it does not make sense to redirect the user to the login form after they log in, we try not to set the login form as the next cookie.

However, the current check is hard-coded to /auth/start/, and the form can also be served at /login/. This has no real effect on normal users, but did make debugging T6870 confusing.

Instead of using a hard-coded path check, test if the controller was delegated to. If it was, store the URI. If it's handling the request without delegation, don't.

Test Plan
  • Visited login form at /login/ and /auth/start/, saw it not set a next URI.
  • Visited login form at /settings/ (while logged out), saw it set a next URI.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Make test for setting "next" cookie more general.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a subscriber: lpriestley.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Jan 9 2015, 12:29 AM
This revision was automatically updated to reflect the committed changes.