Page MenuHomePhabricator
Differential D11287

Auth - restore Phabricator OAuth as a provider
ClosedPublic
Actions

Authored by btrahan on Jan 8 2015, 11:02 PM.
Tags
None
Referenced Files
F13238041: D11287.id27133.diff
Tue, May 21, 4:41 PM
F13203736: D11287.diff
Wed, May 15, 12:05 AM
F13191916: D11287.id27120.diff
Sun, May 12, 2:25 AM
F13191909: D11287.id27133.diff
Sun, May 12, 2:20 AM
F13186264: D11287.diff
Sat, May 11, 3:31 AM
Unknown Object (File)
Tue, May 7, 6:33 AM
Unknown Object (File)
Fri, May 3, 4:02 AM
Unknown Object (File)
Mon, Apr 29, 4:19 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
Restricted Maniphest Task
Commits
Restricted Diffusion Commit
rP2be746fb1f3a: Auth - restore Phabricator OAuth as a provider
Summary

So meta it hurts. Fixes T887.

Test Plan

created a second instance of phabricator locally. made an account on oauth server phabricator. set up my normal dev phabricator to use this new oauth phabricator. noted the form worked. created an account via the oauth method and it worked.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

btrahan updated this revision to Diff 27120.Jan 8 2015, 11:02 PM
btrahan added a task: Restricted Maniphest Task.
btrahan retitled this revision from to Auth - restore Phabricator OAuth as a provider.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptJan 8 2015, 11:02 PM
btrahan mentioned this in D11286: OAuth - add adapter for Phabricator OAuth server.Jan 8 2015, 11:05 PM
btrahan mentioned this in rPHUdc0b7ac01a4f: OAuth - add adapter for Phabricator OAuth server.Jan 8 2015, 11:45 PM
epriestley accepted this revision.Jan 8 2015, 11:50 PM
epriestley edited edge metadata.
epriestley added inline comments.
src/applications/auth/provider/PhabricatorPhabricatorAuthProvider.php
16

I think there's a way to do this in two stages, but we can clean that up in the long run. I think this is reasonably clear.

This revision is now accepted and ready to land.Jan 8 2015, 11:50 PM
btrahan updated this revision to Diff 27133.Jan 9 2015, 12:25 AM
btrahan edited edge metadata.

Make things two steps and re-jigger hint text a bit. I think its betterish now.

btrahan added a comment.Jan 9 2015, 12:26 AM

Screen_Shot_2015-01-08_at_4.19.27_PM.png (1×1 px, 509 KB)

Screen_Shot_2015-01-08_at_4.22.02_PM.png (1×1 px, 444 KB)

Closed by commit rP2be746fb1f3a: Auth - restore Phabricator OAuth as a provider (authored by btrahan, committed by btrahan). · Explain WhyJan 9 2015, 12:28 AM
This revision was automatically updated to reflect the committed changes.
epriestley added a comment.Jan 9 2015, 12:33 AM

so beautiful

btrahan mentioned this in D11294: Auth - fix headers for instructions on Phabricator OAuth provider.Jan 9 2015, 12:36 AM
btrahan mentioned this in rP04fb3defd9b4: Auth - fix headers for instructions on Phabricator OAuth provider.Jan 9 2015, 12:37 AM

Revision Contents
Changeset List

PathSize
src/
2 lines
applications/
auth/
controller/
config/
6 lines
provider/
203 lines

Diff 27134

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/auth/controller/config/PhabricatorAuthEditController.php

Loading...
View Options

src/applications/auth/provider/PhabricatorPhabricatorAuthProvider.php

Loading...
Phabricator · Built by Phacility