Don't say "K&R style" in coding conventions
ClosedPublic
Actions

Authored by epriestley on Jan 6 2015, 6:40 PM.

Tags

None

Referenced Files

	F19119368: D11255.id27014.diff
	Tue, Dec 9, 8:44 PM

	F19116755: D11255.id.diff
	Tue, Dec 9, 7:42 PM

	F19015202: D11255.id27014.diff
	Sat, Nov 22, 11:37 PM

	F18878308: D11255.id.diff
	Nov 6 2025, 4:50 PM

	F18877403: D11255.id27015.diff
	Nov 6 2025, 8:09 AM

	F18873110: D11255.diff
	Nov 5 2025, 8:01 AM

	F18845731: D11255.id27014.diff
	Oct 29 2025, 2:14 PM

	F18843822: D11255.id27015.diff
	Oct 29 2025, 12:59 AM

View All Files

Subscribers

epriestley

Details

Reviewers

btrahan
staticshock

Commits

Restricted Diffusion Commit
rPb2e71bcb7071: Don't say "K&R style" in coding conventions

Summary

We technically don't use K&R. These documents and the rest of the codebase are full of examples of the correct style, which should be unambiguous to a reasonable reader.

Test Plan

reading

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 27014.Jan 6 2015, 6:40 PM

epriestley retitled this revision from to Don't say "K&R style" in coding conventions.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: staticshock, btrahan.

Herald added a subscriber: epriestley. · View Herald TranscriptJan 6 2015, 6:40 PM

btrahan accepted this revision.Jan 6 2015, 6:46 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Jan 6 2015, 6:46 PM

Closed by commit rPb2e71bcb7071: Don't say "K&R style" in coding conventions (authored by epriestley, committed by epriestley). · Explain WhyJan 6 2015, 6:47 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

docs/

contributor/

javascript_coding_standards.diviner

1 line

php_coding_standards.diviner

1 line

Diff 27015

View Options

src/docs/contributor/javascript_coding_standards.diviner