Page MenuHomePhabricator

Projects - display "members" link in disabled style if user can't edit project
ClosedPublic

Authored by btrahan on Jan 5 2015, 11:24 PM.
Tags
None
Referenced Files
F18642799: D11229.id26960.diff
Sep 19 2025, 12:42 AM
F18642797: D11229.id26962.diff
Sep 19 2025, 12:42 AM
F18642796: D11229.id26959.diff
Sep 19 2025, 12:42 AM
Unknown Object (File)
May 26 2025, 12:55 AM
Unknown Object (File)
May 25 2025, 8:28 PM
Unknown Object (File)
May 21 2025, 3:29 AM
Unknown Object (File)
May 11 2025, 7:26 PM
Unknown Object (File)
May 6 2025, 9:08 AM
Subscribers

Details

Summary

Fixes T6862.

Test Plan

viewed a project list and saw disabled-style "Members" links as appropos

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

btrahan retitled this revision from to Projects - display "members" link in disabled style if user can't edit project.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added reviewers: chad, epriestley.
src/applications/project/query/PhabricatorProjectSearchEngine.php
231–242

the other thing I could do here is make "workflow" true in this case, which would make this a nice dialogue and not a full, page re-load 404 nice dialogue.

...do the conditional workflow; seems like a more-standard / better behavior.

chad edited edge metadata.
This revision is now accepted and ready to land.Jan 5 2015, 11:32 PM
btrahan edited edge metadata.

move data loading to before the foreach loop (re-run tests and still good) this change alleviates performance concern

This revision was automatically updated to reflect the committed changes.