Differential D11127

Remove 'Author:' byline text
ClosedPublic
Actions

Authored by chad on Jan 1 2015, 8:35 PM.

Details

Reviewers

epriestley

Commits

Restricted Diffusion Commit
rP61e26cd2421b: Remove 'Author:' byline text

Summary

The actual author here usually gets truncated by the extra text, which doesn't seem needed in most (all?) cases.

Test Plan

Look at list of recent commits.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chad updated this revision to Diff 26719.Jan 1 2015, 8:35 PM

chad retitled this revision from to Remove 'Author:' byline text.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptJan 1 2015, 8:35 PM

epriestley accepted this revision.Jan 2 2015, 6:35 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jan 2 2015, 6:35 PM

Closed by commit rP61e26cd2421b: Remove 'Author:' byline text (authored by chad, committed by chad). · Explain WhyJan 2 2015, 7:39 PM

This revision was automatically updated to reflect the committed changes.

Author name is mostly visible now, but e-mail (at least for Git repositories) is truncated as well.

Maybe we should display recognized Phabricator username (with a link) as we're doing for list of Differential Revisions? And when user isn't detected, then we show original commiter as now.

Right now with "Author: " text removed it doesn't look too consistent with Differential Revisions list.

Revision Contents
Changeset List

Path

Size

src/

applications/

audit/

view/

PhabricatorAuditListView.php

2 lines

Diff 26776

View Options

src/applications/audit/view/PhabricatorAuditListView.php

Remove 'Author:' byline textClosedPublicActions