Page MenuHomePhabricator
Differential D11099

Fix diffusion.readmequery to work in a cluster enviroment
ClosedPublic
Actions

Authored by epriestley on Dec 31 2014, 1:44 AM.
Tags
None
Referenced Files
F13095851: D11099.diff
Thu, Apr 25, 1:16 PM
F13086116: D11099.diff
Thu, Apr 25, 12:04 AM
Unknown Object (File)
Tue, Apr 16, 3:54 AM
Unknown Object (File)
Thu, Apr 11, 8:21 AM
Unknown Object (File)
Tue, Apr 2, 5:10 AM
Unknown Object (File)
Sat, Mar 30, 5:31 AM
Unknown Object (File)
Thu, Mar 28, 6:53 PM
Unknown Object (File)
Mar 5 2024, 1:50 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T2783: Make working-copy operations service-oriented
Commits
Restricted Diffusion Commit
rPcae8c49745cc: Fix diffusion.readmequery to work in a cluster enviroment
Summary

Ref T2783. This method is kind of goofballs:

  • We send a big list of paths to it.
  • It sends back a giant blob of HTML.

Instead, just figure out the path we want locally, then fetch the content with diffusion.filecontentquery.

Test Plan
  • Viewed main view and directory view, saw a README.
  • See screenshots.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 26643.Dec 31 2014, 1:44 AM
epriestley retitled this revision from to Fix diffusion.readmequery to work in a cluster enviroment.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T2783: Make working-copy operations service-oriented.
Herald added a subscriber: epriestley. · View Herald TranscriptDec 31 2014, 1:44 AM
epriestley added a comment.EditedDec 31 2014, 1:45 AM

Before, since we don't explicitly trust the wire response as HTML, we'd get this:

Screen_Shot_2014-12-30_at_5.39.48_PM.png (1×1 px, 542 KB)

After, we get a proper rendering in a cluster:

Screen_Shot_2014-12-30_at_5.39.53_PM.png (1×1 px, 312 KB)

We could have retained a more similar version of this query and trusted the response, but ugh.

btrahan accepted this revision.Dec 31 2014, 7:50 PM
btrahan edited edge metadata.

Whoops, thought I accepted this one yesterday.

This revision is now accepted and ready to land.Dec 31 2014, 7:50 PM
Closed by commit rPcae8c49745cc: Fix diffusion.readmequery to work in a cluster enviroment (authored by epriestley, committed by epriestley). · Explain WhyDec 31 2014, 7:55 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 26655

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/diffusion/conduit/DiffusionReadmeQueryConduitAPIMethod.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionBrowseDirectoryController.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionRepositoryController.php

Loading...
View Options

src/applications/diffusion/data/DiffusionBrowseResultSet.php

Loading...
View Options

src/applications/diffusion/view/DiffusionReadmeView.php

Loading...
Phabricator · Built by Phacility