Page MenuHomePhabricator

Fix diffusion.readmequery to work in a cluster enviroment
ClosedPublic

Authored by epriestley on Dec 31 2014, 1:44 AM.
Tags
None
Referenced Files
F14063996: D11099.diff
Mon, Nov 18, 9:24 PM
F14053266: D11099.diff
Fri, Nov 15, 1:51 PM
F14039151: D11099.diff
Mon, Nov 11, 4:06 AM
F14023435: D11099.diff
Thu, Nov 7, 2:03 AM
F13997059: D11099.diff
Thu, Oct 24, 1:53 AM
F13979482: D11099.id26655.diff
Oct 19 2024, 4:50 AM
F13975088: D11099.diff
Oct 18 2024, 8:41 AM
F13966742: D11099.id.diff
Oct 16 2024, 9:25 AM
Subscribers

Details

Summary

Ref T2783. This method is kind of goofballs:

  • We send a big list of paths to it.
  • It sends back a giant blob of HTML.

Instead, just figure out the path we want locally, then fetch the content with diffusion.filecontentquery.

Test Plan
  • Viewed main view and directory view, saw a README.
  • See screenshots.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Fix diffusion.readmequery to work in a cluster enviroment.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.

Before, since we don't explicitly trust the wire response as HTML, we'd get this:

Screen_Shot_2014-12-30_at_5.39.48_PM.png (1×1 px, 542 KB)

After, we get a proper rendering in a cluster:

Screen_Shot_2014-12-30_at_5.39.53_PM.png (1×1 px, 312 KB)

We could have retained a more similar version of this query and trusted the response, but ugh.

btrahan edited edge metadata.

Whoops, thought I accepted this one yesterday.

This revision is now accepted and ready to land.Dec 31 2014, 7:50 PM
This revision was automatically updated to reflect the committed changes.