Page MenuHomePhabricator

Fix diffusion.readmequery to work in a cluster enviroment
ClosedPublic

Authored by epriestley on Dec 31 2014, 1:44 AM.
Tags
None
Referenced Files
F15435182: D11099.id26643.diff
Tue, Mar 25, 7:18 AM
F15384313: D11099.id26643.diff
Fri, Mar 14, 7:28 PM
F15378582: D11099.id26643.diff
Thu, Mar 13, 3:28 PM
F15376031: D11099.id26655.diff
Thu, Mar 13, 1:24 AM
Unknown Object (File)
Mon, Mar 3, 8:57 PM
Unknown Object (File)
Feb 14 2025, 10:02 AM
Unknown Object (File)
Feb 8 2025, 12:33 AM
Unknown Object (File)
Feb 8 2025, 12:33 AM
Subscribers

Details

Summary

Ref T2783. This method is kind of goofballs:

  • We send a big list of paths to it.
  • It sends back a giant blob of HTML.

Instead, just figure out the path we want locally, then fetch the content with diffusion.filecontentquery.

Test Plan
  • Viewed main view and directory view, saw a README.
  • See screenshots.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Fix diffusion.readmequery to work in a cluster enviroment.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.

Before, since we don't explicitly trust the wire response as HTML, we'd get this:

Screen_Shot_2014-12-30_at_5.39.48_PM.png (1×1 px, 542 KB)

After, we get a proper rendering in a cluster:

Screen_Shot_2014-12-30_at_5.39.53_PM.png (1×1 px, 312 KB)

We could have retained a more similar version of this query and trusted the response, but ugh.

btrahan edited edge metadata.

Whoops, thought I accepted this one yesterday.

This revision is now accepted and ready to land.Dec 31 2014, 7:50 PM
This revision was automatically updated to reflect the committed changes.