Diffusion - fix first "old ref" in push log
ClosedPublic
Actions

Authored by btrahan on Dec 30 2014, 11:07 PM.

Tags

None

Referenced Files

	F14081373: D11096.diff
	Fri, Nov 22, 7:29 PM

	Unknown Object (File)
	Sun, Nov 17, 7:36 PM

	Unknown Object (File)
	Thu, Nov 14, 3:51 AM

	Unknown Object (File)
	Wed, Nov 13, 7:35 AM

	Unknown Object (File)
	Wed, Nov 13, 1:53 AM

	Unknown Object (File)
	Sat, Nov 9, 9:28 PM

	Unknown Object (File)
	Wed, Nov 6, 6:54 AM

	Unknown Object (File)
	Fri, Nov 1, 7:22 AM

View All Files

Subscribers

epriestley

Korvin

Tokens

"Like" token, awarded by epriestley.

Details

Reviewers

epriestley
chad

Maniphest Tasks

T6826: Initial Push In Log shows invalid hash

Commits

Restricted Diffusion Commit
rP12c7c399ce14: Diffusion - fix first "old ref" in push log

Summary

This is a fake hash of many 0s which ends up being a bad link. Detect the fake hash and don't print a link. Fixes T6826.

Test Plan

looked at push log and no longer saw a many 0 entry for the first old ref.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

btrahan updated this revision to Diff 26637.Dec 30 2014, 11:07 PM

btrahan added a task: T6826: Initial Push In Log shows invalid hash.

btrahan retitled this revision from to Diffusion - fix first "old ref" in push log.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added reviewers: epriestley, chad.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptDec 30 2014, 11:07 PM

chad accepted this revision.Dec 30 2014, 11:13 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Dec 30 2014, 11:13 PM

Closed by commit rP12c7c399ce14: Diffusion - fix first "old ref" in push log (authored by btrahan, committed by btrahan). · Explain WhyDec 30 2014, 11:18 PM

This revision was automatically updated to reflect the committed changes.

epriestley awarded a token.Dec 30 2014, 11:34 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

view/

DiffusionPushLogListView.php

16 lines

Diff 26638

View Options

src/applications/diffusion/view/DiffusionPushLogListView.php

Diffusion - fix first "old ref" in push logClosedPublicActions