Page MenuHomePhabricator

Allow archived tasks to be queried by object PHID and order by id
ClosedPublic

Authored by epriestley on Dec 30 2014, 5:47 PM.
Tags
None
Referenced Files
F14481765: D11089.id26626.diff
Mon, Dec 30, 5:12 AM
Unknown Object (File)
Sat, Dec 28, 4:23 PM
Unknown Object (File)
Fri, Dec 27, 2:40 PM
Unknown Object (File)
Thu, Dec 26, 12:27 AM
Unknown Object (File)
Sun, Dec 22, 2:58 AM
Unknown Object (File)
Sun, Dec 22, 2:58 AM
Unknown Object (File)
Sun, Dec 22, 2:58 AM
Unknown Object (File)
Sun, Dec 22, 2:58 AM
Subscribers

Details

Summary

Ref T5402.

Test Plan
  • Queried archived tasks.
  • Grepped for use sites and verified no other callsites are order-sensitive.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Allow archived tasks to be queried by object PHID and order by id.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Dec 30 2014, 6:00 PM
epriestley edited edge metadata.
  • Also copy the objectPHID into the archive task table when archiving a task.
  • And when unarchiving a task.
  • Also allow selecting leased tasks.
epriestley edited edge metadata.

This changed enough that it should probably get a second look in case I did anything goofy.

epriestley edited edge metadata.
  • Use "result set", which reads better than "results set".
  • Correct ordering/comments about the "leased" phase: we do it first, under the theory that those tasks are executing right now, then the unleased tasks are up next, then the expired tasks are further away.
  • Move all of the PHASE_LEASED clauses first, for consistency.
  • churn churn churn
  • When querying task information, reorder results by the original phase order.
btrahan edited edge metadata.

Still looks good. :D

This revision is now accepted and ready to land.Dec 30 2014, 8:53 PM
This revision was automatically updated to reflect the committed changes.