Page MenuHomePhabricator
Differential D11042

Daemons - introduce PhabricatorWorkerArchiveTaskQuery
ClosedPublic
Actions

Authored by btrahan on Dec 23 2014, 10:57 PM.
Tags
None
Referenced Files
F14056378: D11042.diff
Sat, Nov 16, 8:18 PM
F14013699: D11042.id26518.diff
Sat, Nov 2, 10:22 AM
F14013365: D11042.id26519.diff
Sat, Nov 2, 5:13 AM
F13997685: D11042.id26518.diff
Thu, Oct 24, 5:39 AM
F13997586: D11042.id26519.diff
Thu, Oct 24, 5:16 AM
F13972986: D11042.id26519.diff
Oct 17 2024, 10:15 PM
F13971852: D11042.diff
Oct 17 2024, 3:40 PM
Unknown Object (File)
Oct 13 2024, 4:19 AM
View All Files
Subscribers
epriestley
Korvin
Tokens
"Mountain of Wealth" token, awarded by epriestley.

Details

Reviewers
epriestley
Maniphest Tasks
T5402: Record `objectPHID` on queue tasks, as a debugging hint
Commits
Restricted Diffusion Commit
rPa4474a497583: Daemons - introduce PhabricatorWorkerArchiveTaskQuery
Summary

Ref T5402. This cleans up some code and sets us up to use this sort of data more easily later.

Test Plan

viewed the daemon console from the web and the log of a specific archived daemon. both looked good. for other callsites looked really, really carefully.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

btrahan updated this revision to Diff 26518.Dec 23 2014, 10:57 PM
btrahan added a task: T5402: Record `objectPHID` on queue tasks, as a debugging hint.
btrahan retitled this revision from to Daemons - introduce PhabricatorWorkerArchiveTaskQuery.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptDec 23 2014, 10:57 PM
epriestley awarded a token.Dec 23 2014, 11:29 PM
epriestley accepted this revision.Dec 23 2014, 11:32 PM
epriestley edited edge metadata.

One typo inline, I think.

src/applications/daemon/controller/PhabricatorWorkerTaskDetailController.php
21

Should be reset($tasks)?

This revision is now accepted and ready to land.Dec 23 2014, 11:32 PM
Closed by commit rPa4474a497583: Daemons - introduce PhabricatorWorkerArchiveTaskQuery (authored by btrahan, committed by btrahan). · Explain WhyDec 23 2014, 11:46 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 26519

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/daemon/controller/PhabricatorDaemonConsoleController.php

Loading...
View Options

src/applications/daemon/controller/PhabricatorWorkerTaskDetailController.php

Loading...
View Options

src/applications/daemon/garbagecollector/PhabricatorDaemonTaskGarbageCollector.php

Loading...
View Options

src/infrastructure/daemon/workers/PhabricatorWorker.php

Loading...
View Options

src/infrastructure/daemon/workers/management/PhabricatorWorkerManagementWorkflow.php

Loading...
View Options

src/infrastructure/daemon/workers/query/PhabricatorWorkerArchiveTaskQuery.php

Loading...
Phabricator · Built by Phacility