Page MenuHomePhabricator

Maniphest - convert old CC transactions to modern SUBSCRIBER transactions
ClosedPublic

Authored by btrahan on Dec 18 2014, 10:33 PM.
Tags
None
Referenced Files
F13469099: D11015.id26451.diff
Wed, Jul 17, 3:27 AM
F13464128: D11015.diff
Mon, Jul 15, 9:33 PM
F13436641: D11015.id26451.diff
Thu, Jul 11, 10:28 AM
F13410655: D11015.id26449.diff
Sat, Jul 6, 4:26 PM
F13294871: D11015.id26451.diff
Jun 5 2024, 8:26 PM
F13294870: D11015.id.diff
Jun 5 2024, 8:26 PM
F13294867: D11015.id26449.diff
Jun 5 2024, 8:26 PM
F13294314: D11015.diff
Jun 5 2024, 4:33 PM
Subscribers

Details

Summary

database migration + drop old view code. Fixes T5604.

Test Plan

grepped src/ for TYPE_CCS (no hits); viewed some tasks with old cc transactions and noted they still rendered correctly post data conversion

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

btrahan retitled this revision from to Maniphest - convert old CC transactions to modern SUBSCRIBER transactions.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
epriestley edited edge metadata.

Couple of minor inlines.

resources/sql/autopatches/20141218.maniphestcctxn.php
12

This comment seems wrong?

13

Can we just use the constant?

14

You should:

queryfx(..., 'UPDATE %T SET transactionType = %s WHERE id = %d', ...);

...to future-proof this migration against schema changes to this table.

This revision is now accepted and ready to land.Dec 18 2014, 10:38 PM
This revision was automatically updated to reflect the committed changes.