Differential D11015

Maniphest - convert old CC transactions to modern SUBSCRIBER transactions
ClosedPublic
Actions

Authored by btrahan on Dec 18 2014, 10:33 PM.

Tags

None

Referenced Files

	F14475143: D11015.id26451.diff
	Fri, Dec 27, 5:54 PM

	Unknown Object (File)
	Tue, Dec 24, 10:29 AM

	Unknown Object (File)
	Tue, Dec 24, 10:29 AM

	Unknown Object (File)
	Tue, Dec 24, 10:29 AM

	Unknown Object (File)
	Tue, Dec 24, 10:12 AM

	Unknown Object (File)
	Fri, Dec 20, 8:05 PM

	Unknown Object (File)
	Thu, Dec 19, 4:34 PM

	Unknown Object (File)
	Thu, Dec 19, 12:57 AM

Subscribers

Details

Reviewers

Maniphest Tasks

T5604: Properly integrate Maniphest with Subscribers

Commits

Restricted Diffusion Commit
rP9141da84c85c: Maniphest - convert old CC transactions to modern SUBSCRIBER transactions

Summary

database migration + drop old view code. Fixes T5604.

Test Plan

grepped src/ for TYPE_CCS (no hits); viewed some tasks with old cc transactions and noted they still rendered correctly post data conversion

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

btrahan updated this revision to Diff 26449.Dec 18 2014, 10:33 PM

btrahan added a task: T5604: Properly integrate Maniphest with Subscribers.

btrahan retitled this revision from to Maniphest - convert old CC transactions to modern SUBSCRIBER transactions.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added a reviewer: epriestley.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptDec 18 2014, 10:33 PM

Couple of minor inlines.

resources/sql/autopatches/20141218.maniphestcctxn.php
12	This comment seems wrong?
13	Can we just use the constant?
14	You should: queryfx(..., 'UPDATE %T SET transactionType = %s WHERE id = %d', ...); ...to future-proof this migration against schema changes to this table.

This revision is now accepted and ready to land.Dec 18 2014, 10:38 PM

Closed by commit rP9141da84c85c: Maniphest - convert old CC transactions to modern SUBSCRIBER transactions (authored by btrahan, committed by btrahan). · Explain WhyDec 18 2014, 10:42 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

sql/

autopatches/

20141218.maniphestcctxn.php

20 lines

src/

applications/

maniphest/

storage/

ManiphestTransaction.php

31 lines

Diff 26451

resources/sql/autopatches/20141218.maniphestcctxn.php

Loading...

src/applications/maniphest/storage/ManiphestTransaction.php

Loading...