Makes the header text clickable to the full results.
Details
Details
- Reviewers
epriestley btrahan - Commits
- Restricted Diffusion Commit
rP05c13857afdf: Link search query to Dashboard header title
Click on a few queries.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| src/applications/dashboard/engine/PhabricatorDashboardPanelRenderingEngine.php | ||
|---|---|---|
| 227–235 | Can we drop this try/catch? It's unusual to silence an exception like this. Is there any reason this exception should occur normally? | |
Comment Actions
fwiw, i tried various icons/text on the right of the header and all were very heavy. I linked the title which is actually helpful, but hidden. I would possibly like to display the result count in the header like:
Open Tasks (12 of 82)
Or just:
Open Tasks (82)
Is getting counts reasonable? I'm fine with (99+) type limitations.
Comment Actions
It's not straightforward given how the queries work right now, but we could implement it in the future without tooooo much trouble.
One vague concern is that showing "10 of 99+" makes the panel approximately 10x more expensive to build. Just showing some kind of "there are more results" at the bottom-ish might accomplish the same thing but only require us to load one extra object?
Comment Actions
Will tab panels be supported in future. Right now when panel is included as tab on tab panel, then clicking on tab will switch to that tab, which is correct.
Maybe we can add "Show All" link at the bottom of the panel when it's included as part of tab panel?