Paths

Table of Contentst

Differential D11001

Rename "Local" settings in Diffusion to "Storage"
ClosedPublic
Actions

Authored by epriestley on Dec 17 2014, 3:03 PM.

Tags

None

Referenced Files

	F15515964: D11001.id26415.diff
	Fri, Apr 18, 2:52 PM

	F15474381: D11001.diff
	Sun, Apr 6, 8:15 AM

	F15472703: D11001.id26415.diff
	Sat, Apr 5, 3:35 PM

	F15469411: D11001.diff
	Fri, Apr 4, 12:56 PM

	F15419529: D11001.diff
	Fri, Mar 21, 6:49 AM

	F15396827: D11001.id26425.diff
	Mar 16 2025, 4:31 PM

	F15396077: D11001.id26424.diff
	Mar 16 2025, 11:42 AM

	F15395391: D11001.id26415.diff
	Mar 16 2025, 6:38 AM

Subscribers

Details

Reviewers

Maniphest Tasks

T2783: Make working-copy operations service-oriented

Commits

Restricted Diffusion Commit
rPd8739459f6f9: Rename "Local" settings in Diffusion to "Storage"

Summary

Ref T2783. In Diffusion -> Edit Repository, we currently have a section called "Local" with options about where the repository is stored. The current name is misleading in a cluster environment, where storage may not actually be local. Shortly, this will also have an option for cluster storage. Call this "Storage" instead.

Test Plan

Edited a repository and poked around.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 26415.Dec 17 2014, 3:03 PM

epriestley retitled this revision from to Rename "Local" settings in Diffusion to "Storage".

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T2783: Make working-copy operations service-oriented.

Herald added a subscriber: epriestley. · View Herald TranscriptDec 17 2014, 3:03 PM

btrahan accepted this revision.Dec 17 2014, 5:12 PM

btrahan edited edge metadata.

btrahan added inline comments.

src/applications/diffusion/controller/DiffusionRepositoryEditMainController.php
87	change the variable name too?

This revision is now accepted and ready to land.Dec 17 2014, 5:12 PM

Rename $local_properties to $storage_properties.

Closed by commit rPd8739459f6f9: Rename "Local" settings in Diffusion to "Storage" (authored by epriestley, committed by epriestley). · Explain WhyDec 17 2014, 7:13 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

4 lines

applications/

diffusion/

application/

PhabricatorDiffusionApplication.php

2 lines

controller/

DiffusionRepositoryEditLocalController.php

DiffusionRepositoryEditMainController.php

22 lines

	DiffusionRepositoryEditStorageController.php
	DiffusionRepositoryEditLocalController.php

4 lines

Diff 26425

src/__phutil_library_map__.php

Loading...

src/applications/diffusion/application/PhabricatorDiffusionApplication.php

Loading...

src/applications/diffusion/controller/DiffusionRepositoryEditLocalController.php

Loading...

src/applications/diffusion/controller/DiffusionRepositoryEditMainController.php

Loading...

src/applications/diffusion/controller/DiffusionRepositoryEditStorageController.php

Loading...