Page MenuHomePhabricator

Prevent Phame blogs from using invalid skins
ClosedPublic

Authored by epriestley on Dec 15 2014, 6:26 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jan 29, 9:16 AM
Unknown Object (File)
Wed, Jan 29, 6:30 AM
Unknown Object (File)
Wed, Jan 22, 12:22 AM
Unknown Object (File)
Mon, Jan 20, 3:33 AM
Unknown Object (File)
Sat, Jan 18, 12:08 AM
Unknown Object (File)
Fri, Jan 17, 3:37 PM
Unknown Object (File)
Tue, Jan 7, 1:06 AM
Unknown Object (File)
Sat, Jan 4, 8:38 PM
Subscribers

Details

Reviewers
btrahan
Commits
Restricted Diffusion Commit
rP2037979142cb: Prevent Phame blogs from using invalid skins
Summary

Via HackerOne. An attacker with access to both Phame and the filesystem could potentially load a skin that lives outside of the configured skin directories, because we had insufficient checks on the actual skin at load time.

Test Plan

Attempted to build a blog with an invalid skin; got an exception instead of a mis-load of a sketchy skin.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Prevent Phame blogs from using invalid skins.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Dec 15 2014, 6:41 PM
This revision was automatically updated to reflect the committed changes.