Page MenuHomePhabricator

Prevent Phame blogs from using invalid skins
ClosedPublic

Authored by epriestley on Dec 15 2014, 6:26 PM.
Tags
None
Referenced Files
F19032266: D10992.diff
Tue, Nov 25, 5:47 AM
F18818126: D10992.id26388.diff
Oct 21 2025, 9:17 PM
F18748590: D10992.id.diff
Oct 3 2025, 11:33 PM
F18743097: D10992.diff
Oct 2 2025, 10:22 PM
F18703479: D10992.id26388.diff
Sep 28 2025, 4:08 AM
F18624669: D10992.diff
Sep 15 2025, 8:44 PM
F18252919: D10992.id.diff
Aug 21 2025, 8:59 PM
F18237473: D10992.diff
Aug 20 2025, 9:26 PM
Subscribers

Details

Reviewers
btrahan
Commits
Restricted Diffusion Commit
rP2037979142cb: Prevent Phame blogs from using invalid skins
Summary

Via HackerOne. An attacker with access to both Phame and the filesystem could potentially load a skin that lives outside of the configured skin directories, because we had insufficient checks on the actual skin at load time.

Test Plan

Attempted to build a blog with an invalid skin; got an exception instead of a mis-load of a sketchy skin.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Prevent Phame blogs from using invalid skins.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Dec 15 2014, 6:41 PM
This revision was automatically updated to reflect the committed changes.