Page MenuHomePhabricator

Use more liberal whitespae detection for `%%%` and `---` remarkup rules
ClosedPublic

Authored by epriestley on Dec 11 2014, 5:58 PM.
Tags
None
Referenced Files
F13196057: D10972.diff
Sun, May 12, 10:54 PM
F13179834: D10972.diff
Wed, May 8, 9:28 PM
Unknown Object (File)
Sat, May 4, 7:08 PM
Unknown Object (File)
Wed, May 1, 12:40 AM
Unknown Object (File)
Fri, Apr 19, 12:12 PM
Unknown Object (File)
Apr 12 2024, 3:45 PM
Unknown Object (File)
Apr 12 2024, 3:20 AM
Unknown Object (File)
Apr 5 2024, 3:36 PM
Subscribers

Details

Summary

This relaxes detection of whitespace for literal blocks and horizontal lines. In particular, when these rules are quoted, they appear as, e.g., > ---, which currently does not show a quoted horizontal line.

Test Plan

Added and ran unit tests. Quoted literal and HR rules.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Use more liberal whitespae detection for `%%%` and `---` remarkup rules.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: btrahan, chad.
btrahan edited edge metadata.

Yay unit tests! Much better than my brain for proving regex correctness. :D

This revision is now accepted and ready to land.Dec 11 2014, 6:30 PM
This revision was automatically updated to reflect the committed changes.