Page MenuHomePhabricator
Differential D10972

Use more liberal whitespae detection for `%%%` and `---` remarkup rules
ClosedPublic
Actions

Authored by epriestley on Dec 11 2014, 5:58 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Feb 7, 9:39 AM
Unknown Object (File)
Thu, Jan 30, 12:08 PM
Unknown Object (File)
Wed, Jan 29, 7:59 AM
Unknown Object (File)
Tue, Jan 28, 6:05 AM
Unknown Object (File)
Tue, Jan 28, 6:05 AM
Unknown Object (File)
Tue, Jan 28, 6:05 AM
Unknown Object (File)
Tue, Jan 28, 5:58 AM
Unknown Object (File)
Sat, Jan 25, 5:08 PM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
chad
Commits
rPHU31e03271e0bc: Use more liberal whitespae detection for `%%%` and `---` remarkup rules
Summary

This relaxes detection of whitespace for literal blocks and horizontal lines. In particular, when these rules are quoted, they appear as, e.g., > ---, which currently does not show a quoted horizontal line.

Test Plan

Added and ran unit tests. Quoted literal and HR rules.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 26348.Dec 11 2014, 5:58 PM
epriestley retitled this revision from to Use more liberal whitespae detection for `%%%` and `---` remarkup rules.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: btrahan, chad.
Herald added a subscriber: epriestley. · View Herald TranscriptDec 11 2014, 5:58 PM
btrahan accepted this revision.Dec 11 2014, 6:30 PM
btrahan edited edge metadata.

Yay unit tests! Much better than my brain for proving regex correctness. :D

This revision is now accepted and ready to land.Dec 11 2014, 6:30 PM
Closed by commit rPHU31e03271e0bc: Use more liberal whitespae detection for `%%%` and `---` remarkup rules (authored by epriestley, committed by epriestley). · Explain WhyDec 11 2014, 6:32 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
markup/
engine/
__tests__/
remarkup/
18 lines
6 lines
remarkup/
blockrule/
6 lines
16 lines

Diff 26354

View Options

src/markup/engine/__tests__/remarkup/horizonal-rule.txt

Loading...
View Options

src/markup/engine/__tests__/remarkup/percent-block-oneline.txt

Loading...
View Options

src/markup/engine/remarkup/blockrule/PhutilRemarkupHorizontalRuleBlockRule.php

Loading...
View Options

src/markup/engine/remarkup/blockrule/PhutilRemarkupLiteralBlockRule.php

Loading...
Phabricator · Built by Phacility