Move 'Contains Text' on Maniphest Query to be above page fold
AbandonedPublic
Actions

Authored by chad on Dec 11 2014, 4:37 AM.

Details

Reviewers

epriestley
btrahan

Maniphest Tasks

T6717: Improving the usability of Maniphest's advanced search

Summary

Ref T6717, moves field to be more easily accessed

Test Plan

Pull up a query, see field in new position, perform search as expected.

Diff Detail

Repository

rP Phabricator

Branch

maniphest-move-contains-words

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 3229
Build 3235: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad updated this revision to Diff 26341.Dec 11 2014, 4:37 AM

chad retitled this revision from to Move 'Contains Text' on Maniphest Query to be above page fold.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added reviewers: epriestley, btrahan.

chad added a task: T6717: Improving the usability of Maniphest's advanced search.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptDec 11 2014, 4:37 AM

chad added inline comments.Dec 11 2014, 4:40 AM

src/applications/maniphest/query/ManiphestTaskSearchEngine.php
376	should we change these to consistently say "Query" as well?

epriestley requested changes to this revision.Dec 11 2014, 12:06 PM

epriestley edited edge metadata.

epriestley added inline comments.

src/applications/maniphest/query/ManiphestTaskSearchEngine.php
376	Users find "Contains Text" confusing. See T4818.

This revision now requires changes to proceed.Dec 11 2014, 12:06 PM

I derped this inside an uncommitted branch

Revision Contents
Changeset List

Path

Size

src/

applications/

maniphest/

query/

ManiphestTaskSearchEngine.php

10 lines

Diff 26341

View Options

src/applications/maniphest/query/ManiphestTaskSearchEngine.php

Move 'Contains Text' on Maniphest Query to be above page foldAbandonedPublicActions