Page MenuHomePhabricator

Allow ConduitClient to specify an explicit Host
ClosedPublic

Authored by epriestley on Dec 10 2014, 6:21 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 17, 1:57 PM
Unknown Object (File)
Fri, Apr 5, 5:35 AM
Unknown Object (File)
Fri, Apr 5, 5:05 AM
Unknown Object (File)
Mon, Apr 1, 1:57 AM
Unknown Object (File)
Sun, Mar 31, 6:47 PM
Unknown Object (File)
Sat, Mar 30, 11:12 PM
Unknown Object (File)
Sat, Mar 30, 8:42 PM
Unknown Object (File)
Sat, Mar 30, 7:43 PM
Subscribers

Details

Summary

Ref T2783. To query a repository, we want to connect to a node which hosts it, but also connect using the correct instance hostname.

Allow ConduitClient to specify an explicit hostname.

Test Plan

Used a script like this to verify that setHost() is impactful:

<?php

require_once 'scripts/__init_script__.php';

$response = id(new ConduitClient('http://127.0.0.1/'))
  ->setHost('local.phacility.com')
  ->callMethodSynchronous('conduit.ping', array());

var_dump($response);

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Allow ConduitClient to specify an explicit Host.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Dec 10 2014, 9:29 PM
This revision was automatically updated to reflect the committed changes.