Page MenuHomePhabricator

transactionTimelineCallback a good idea?
AbandonedPublic

Authored by btrahan on Dec 4 2014, 8:12 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 19, 1:20 PM
Unknown Object (File)
Thu, Dec 19, 1:20 PM
Unknown Object (File)
Thu, Dec 19, 1:20 PM
Unknown Object (File)
Nov 25 2024, 6:04 AM
Unknown Object (File)
Nov 21 2024, 1:47 PM
Unknown Object (File)
Nov 17 2024, 10:18 PM
Unknown Object (File)
Nov 17 2024, 1:37 AM
Unknown Object (File)
Nov 14 2024, 10:46 AM
Subscribers

Details

Summary

Ref T6693

Test Plan

NA

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 3179
Build 3185: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan retitled this revision from to transactionTimelineCallback a good idea?.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
btrahan set the repository for this revision to rP Phabricator.

Would love feedback on the approach, method name(s), and whether or not I should be able to get the left / right side diff IDs from $request before I deploy this a hojillion places.

For consistency, maybe call it willRenderTimeline()?

whether or not I should be able to get the left / right side diff IDs from $request before I deploy this a hojillion places

Oh, yuck. You probably don't have enough information to figure it out unless you add more information to the AJAX request.

Maybe the method needs to let you pass extra data, which is embedded in the timeline on the first render, and then passed to the server in the AJAX request so the callback sees the same view of the world in all cases.

btrahan edited edge metadata.

updates so that Differential now works as does Pholio...

Now I just need to put a no op implementation 83 other places.