Page MenuHomePhabricator

Transactions - kill the old "show all" code pathways

Authored by btrahan on Dec 4 2014, 5:11 AM.
Referenced Files
F13330064: D10926.diff
Mon, Jun 17, 2:33 AM
F13317854: D10926.diff
Thu, Jun 13, 9:58 AM
F13306203: D10926.diff
Sun, Jun 9, 7:36 AM
F13305781: D10926.diff
Sun, Jun 9, 12:55 AM
F13293046: D10926.diff
Wed, Jun 5, 6:29 AM
Sun, Jun 2, 3:02 PM
F13259492: D10926.id26245.diff
Sun, May 26, 9:16 PM
F13243833: D10926.diff
May 23 2024, 4:16 AM



we still need to be pager-sensitive, but otherwise this "show all" stuff is dead, dead dead...! Ref T4712. I think we can close the book on T4712 with one more diff to clean up the array_reverse / reverse paging stuff? That diff is probably a bit tricky as it involes auditing every TransactionQuery callsite...

Test Plan

viewed a task with a lot of transactions. clicked "show older" and it worked!

Diff Detail

rP Phabricator
Lint Not Applicable
Tests Not Applicable

Event Timeline

btrahan retitled this revision from to Transactions - kill the old "show all" code pathways.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Dec 4 2014, 11:41 AM
This revision was automatically updated to reflect the committed changes.