Differential D10926

Transactions - kill the old "show all" code pathways
ClosedPublic
Actions

Authored by btrahan on Dec 4 2014, 5:11 AM.

Tags

None

Referenced Files

	F14713919: D10926.diff
	Fri, Jan 17, 4:54 PM

	F14709522: D10926.id26245.diff
	Fri, Jan 17, 12:56 PM

	Unknown Object (File)
	Thu, Jan 16, 10:31 AM

	Unknown Object (File)
	Fri, Jan 3, 4:11 AM

	Unknown Object (File)
	Thu, Dec 26, 1:17 PM

	Unknown Object (File)
	Fri, Dec 20, 8:29 AM

	Unknown Object (File)
	Thu, Dec 19, 1:19 PM

	Unknown Object (File)
	Thu, Dec 19, 1:19 PM

Subscribers

Details

Reviewers

Maniphest Tasks

T4712: Paginate transactions on objects once there are a huge number of them

Commits

Restricted Diffusion Commit
rP2856c6093240: Transactions - kill the old "show all" code pathways

Summary

we still need to be pager-sensitive, but otherwise this "show all" stuff is dead, dead dead...! Ref T4712. I think we can close the book on T4712 with one more diff to clean up the array_reverse / reverse paging stuff? That diff is probably a bit tricky as it involes auditing every TransactionQuery callsite...

Test Plan

viewed a task with a lot of transactions. clicked "show older" and it worked!

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

btrahan updated this revision to Diff 26245.Dec 4 2014, 5:11 AM

btrahan added a task: T4712: Paginate transactions on objects once there are a huge number of them.

btrahan retitled this revision from to Transactions - kill the old "show all" code pathways.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added a reviewer: epriestley.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptDec 4 2014, 5:11 AM

epriestley accepted this revision.Dec 4 2014, 11:41 AM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Dec 4 2014, 11:41 AM

Closed by commit rP2856c6093240: Transactions - kill the old "show all" code pathways (authored by btrahan, committed by btrahan). · Explain WhyDec 4 2014, 10:55 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

11 lines

2 lines

src/

view/

phui/

PHUITimelineView.php

76 lines

webroot/

rsrc/

js/

application/

differential/

behavior-show-all-comments.js

Diff 26258

resources/celerity/map.php

Loading...

resources/celerity/packages.php

Loading...

src/view/phui/PHUITimelineView.php

Loading...

webroot/rsrc/js/application/differential/behavior-show-all-comments.js

Loading...