Page MenuHomePhabricator

Transactions - kill the old "show all" code pathways
ClosedPublic

Authored by btrahan on Dec 4 2014, 5:11 AM.
Tags
None
Attached Files
Unknown Object (File)
Apr 14 2017, 4:09 PM
Unknown Object (File)
Apr 14 2017, 2:57 AM
Unknown Object (File)
Apr 11 2017, 1:31 AM
Unknown Object (File)
Mar 10 2017, 9:44 AM
Unknown Object (File)
Feb 16 2017, 10:25 AM
Unknown Object (File)
Feb 16 2017, 10:25 AM
Unknown Object (File)
Feb 16 2017, 10:25 AM
Unknown Object (File)
Feb 14 2017, 1:49 AM
Subscribers

Details

Summary

we still need to be pager-sensitive, but otherwise this "show all" stuff is dead, dead dead...! Ref T4712. I think we can close the book on T4712 with one more diff to clean up the array_reverse / reverse paging stuff? That diff is probably a bit tricky as it involes auditing every TransactionQuery callsite...

Test Plan

viewed a task with a lot of transactions. clicked "show older" and it worked!

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

btrahan retitled this revision from to Transactions - kill the old "show all" code pathways.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Dec 4 2014, 11:41 AM
This revision was automatically updated to reflect the committed changes.