Page MenuHomePhabricator

Transactions - deploy buildTransactionTimeline to remaining applications
ClosedPublic

Authored by btrahan on Dec 3 2014, 10:47 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 11 2024, 4:33 PM
Unknown Object (File)
Jan 28 2024, 2:01 AM
Unknown Object (File)
Jan 24 2024, 1:35 PM
Unknown Object (File)
Jan 22 2024, 2:17 PM
Unknown Object (File)
Jan 16 2024, 7:26 AM
Unknown Object (File)
Jan 10 2024, 5:03 PM
Unknown Object (File)
Jan 10 2024, 5:03 PM
Unknown Object (File)
Jan 10 2024, 5:03 PM
Subscribers

Details

Summary

Ref T4712. Specifically...

  • Differential
    • needed getApplicationTransactionViewObject() implemented
  • Audit
    • needed getApplicationTransactionViewObject() implemented
  • Repository
    • one object needed PhabricatorApplicationTransactionInterface implemented
    • setShouldTerminate(true)
  • Ponder
    • BONUS BUG FIX - leaving a comment on an answer had a bad redirect URI
    • both PonderQuestion and PonderAnswer needed PhabricatorApplicationTransactionInterface implemented
    • setShouldTerminate(true) on both "history" controllers
    • left a "TODO" on buildAnswers on the question view controller, which is non-standard and should be re-written eventually
  • Phortune
    • BONUS BUG FIX - fix new user "createNewAccount" code to not fatal
    • PhortuneAccount, PhortuneMerchant, and PhortuneCart needed PhabricatorApplicationTransactionInterface implemented
    • setShouldTerminate(true) on Account view, merchant view, and cart view controller
  • Fund
  • Legalpad
  • Nuance
    • NuanceSource needed PhabricatorApplicationTransactionInterface implemented
  • Releeph (this product is kind of a mess...)
    • HACKQUEST - had to manually create an arcanist project to even be able to make a "product" and get started...!
    • BONUS BUG FIX - make sure to "setName" on product edit
    • ReleephProject (should be ReleepProduct...?), ReleephBranch, and ReleepRequest needed PhabricatorApplicationTransactionInterface implemented
  • Harbormaster
    • HarbormasterBuildable, HarbormasterBuild, HarbormasterBuildPlan, and HarbormasterBuildStep all needed PhabricatorApplicationTransactionInterface implemented
    • setShouldTerminate(true) all over the place
Test Plan

foreach application, viewed the timeline(s) and made sure they still rendered

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

btrahan retitled this revision from to Transactions - deploy buildTransactionTimeline to remaining applications.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Dec 3 2014, 11:27 PM
This revision was automatically updated to reflect the committed changes.