Paths

Table of Contentst

Disallow `[1]` from being interpreted as a marked checkbox in remarkup
ClosedPublic
Actions

Authored by epriestley on Dec 1 2014, 9:35 PM.

Details

Reviewers

btrahan
chad

Maniphest Tasks

T6640: [<number>] should not be interpreted as [X] in Remarkup

Commits

rPHU549aa1bf1485: Disallow `[1]` from being interpreted as a marked checkbox in remarkup

Summary

Fixes T6640. [1] and similar are more likely footnotes than checkmarks.

Test Plan

Screen_Shot_2014-12-01_at_1.34.19_PM.png (586×619 px, 35 KB)

Diff Detail

Repository

rPHU libphutil

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 26212.Dec 1 2014, 9:35 PM

epriestley retitled this revision from to Disallow `[1]` from being interpreted as a marked checkbox in remarkup.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: chad, btrahan.

epriestley added a task: T6640: [<number>] should not be interpreted as [X] in Remarkup.

Herald added a subscriber: epriestley. · View Herald TranscriptDec 1 2014, 9:35 PM

Harbormaster completed remote builds in B3156: Diff 26212.Dec 1 2014, 9:36 PM

chad accepted this revision.Dec 1 2014, 9:36 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Dec 1 2014, 9:36 PM

Closed by commit rPHU549aa1bf1485: Disallow `[1]` from being interpreted as a marked checkbox in remarkup (authored by epriestley, committed by epriestley). · Explain WhyDec 1 2014, 9:38 PM

This revision was automatically updated to reflect the committed changes.

• chasemp added a subscriber: • chasemp.Dec 2 2014, 1:30 AM

Revision Contents
Changeset List

Path

Size

src/

markup/

engine/

__tests__/

remarkup/

list-checkboxes.txt

6 lines

remarkup/

blockrule/

PhutilRemarkupListBlockRule.php

9 lines

Diff 26213

View Options

src/markup/engine/tests/remarkup/list-checkboxes.txt

View Options

src/markup/engine/remarkup/blockrule/PhutilRemarkupListBlockRule.php

Disallow `[1]` from being interpreted as a marked checkbox in remarkupClosedPublicActions