Page MenuHomePhabricator

Don't show meme Remarkup hint button if Macro application is not usable
ClosedPublic

Authored by epriestley on Nov 24 2014, 11:23 PM.

Details

Summary

See https://phabricator.wikimedia.org/T906. This behavior is a bug; we should remove the button if the user can't use the application.

Test Plan
  • With Macro uninstalled, did these things verifying the button vanished:
    • Sent a user a message.
    • Edited a revision.
    • Edited repository basic information.
    • Edited an initiative.
    • Edited a Harbormaster build step.
    • Added task comments.
    • Edited profile blurb.
    • Edited blog description.
    • Commented on Pholio mock.
    • Uploaded Pholio image.
    • Edited Phortune merchant.
    • Edited Phriction document.
    • Edited Ponder answer.
    • Edited Ponder question.
    • Edited Slowvote poll.
    • Edited a comment.
  • Reinstalled Macro and saw button come back.
  • Used button to put silly text on a funny picture.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley retitled this revision from to Don't show meme Remarkup hint button if Macro application is not usable.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: btrahan, chad.
chad accepted this revision.Nov 24 2014, 11:24 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 24 2014, 11:24 PM
This revision was automatically updated to reflect the committed changes.