Align form captions with form elements
ClosedPublic
Actions

Authored by chad on Nov 21 2014, 5:06 PM.

Tags

None

Referenced Files

	F14061957: D10891.diff
	Mon, Nov 18, 9:35 AM

	F14046479: D10891.diff
	Wed, Nov 13, 9:29 PM

	F14034446: D10891.diff
	Sun, Nov 10, 12:21 AM

	F14018910: D10891.diff
	Tue, Nov 5, 8:31 PM

	F14012182: D10891.id26156.diff
	Fri, Nov 1, 7:59 AM

	F13993212: D10891.id26158.diff
	Tue, Oct 22, 9:28 PM

	F13962412: D10891.id.diff
	Oct 15 2024, 9:54 AM

	Unknown Object (File)
	Oct 13 2024, 9:20 PM

View All Files

Subscribers

epriestley

Korvin

Details

Reviewers

epriestley
btrahan

Commits

Restricted Diffusion Commit
rP31c09b7d6aec: Align form captions with form elements

Summary

Make captions feel less floaty, align with their input element.

Test Plan

Visit a few forms with captions, test mobile and desktop layouts

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chad updated this revision to Diff 26156.Nov 21 2014, 5:06 PM

chad retitled this revision from to Align form captions with form elements.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added reviewers: epriestley, btrahan.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptNov 21 2014, 5:06 PM

Harbormaster completed remote builds in B3121: Diff 26156.Nov 21 2014, 5:07 PM

chad edited the test plan for this revision. (Show Details)Nov 21 2014, 5:07 PM

epriestley accepted this revision.Nov 21 2014, 7:07 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Nov 21 2014, 7:07 PM

Closed by commit rP31c09b7d6aec: Align form captions with form elements (authored by chad, committed by chad). · Explain WhyNov 21 2014, 7:16 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

6 lines

webroot/

rsrc/

css/

phui/

phui-form-view.css

5 lines

Diff 26158

View Options

resources/celerity/map.php