Differential D10885

Handle SSH generated keys in Conduit passphrase.query
ClosedPublic
Actions

Authored by dereckson on Nov 20 2014, 2:32 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T6601: PassphraseQueryConduitAPIMethod doesn't handle material for PassphraseCredentialTypeSSHGeneratedKey

Commits

Restricted Diffusion Commit
rPc07425c534e0: Handle SSH generated keys in Conduit passphrase.query

Required Signatures

L28 Phacility Individual Contributor License Agreement

Summary

Fixes T6601

Test Plan

echo '{"ids":["71"],"needPublicKeys":true,"needSecrets":false}' | arc call-conduit passphrase.query

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dereckson updated this revision to Diff 26142.Nov 20 2014, 2:32 AM

dereckson retitled this revision from to Handle SSH generated keys in Conduit passphrase.query.

dereckson updated this object.

dereckson edited the test plan for this revision. (Show Details)

dereckson added a task: T6601: PassphraseQueryConduitAPIMethod doesn't handle material for PassphraseCredentialTypeSSHGeneratedKey.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptNov 20 2014, 2:32 AM

Herald added a required legal document: L28 Phacility Individual Contributor License Agreement. · View Herald Transcript

Herald added a subscriber: epriestley. · View Herald Transcript

Harbormaster completed remote builds in B3111: Diff 26142.Nov 20 2014, 2:33 AM

dereckson planned changes to this revision.Nov 20 2014, 2:43 AM

This comment was removed by dereckson.

dereckson requested a review of this revision.Nov 20 2014, 2:52 AM

epriestley accepted this revision.Nov 21 2014, 7:08 PM

epriestley added a reviewer: epriestley.

This revision is now accepted and ready to land.Nov 21 2014, 7:08 PM

Closed by commit rPc07425c534e0: Handle SSH generated keys in Conduit passphrase.query (authored by dereckson, committed by epriestley). · Explain WhyNov 21 2014, 7:10 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

passphrase/

conduit/

PassphraseQueryConduitAPIMethod.php

1 line

Diff 26157

View Options

src/applications/passphrase/conduit/PassphraseQueryConduitAPIMethod.php

Handle SSH generated keys in Conduit passphrase.queryClosedPublicActions