Don't add "To/Cc" to HTML mail bodies if there's no HTML mail body
ClosedPublic
Actions

Authored by epriestley on Nov 17 2014, 9:41 PM.

Details

Reviewers

btrahan
chad

Maniphest Tasks

T6576: HTML bodies are not passed to all emails

Commits

Restricted Diffusion Commit
rPba778cffd744: Don't add "To/Cc" to HTML mail bodies if there's no HTML mail body

Summary

Ref T6576. This avoids generating almost-empty HTML mail bodies for mail which incorrectly has no HTML body.

Test Plan

Generated some mail locally; the specific hook case is a pain for me to hit right now. Will push and dig in if that doesn't fix it.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 26085.Nov 17 2014, 9:41 PM

epriestley retitled this revision from to Don't add "To/Cc" to HTML mail bodies if there's no HTML mail body.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: chad, btrahan.

epriestley added a task: T6576: HTML bodies are not passed to all emails.

Herald added a subscriber: epriestley. · View Herald TranscriptNov 17 2014, 9:41 PM

chad accepted this revision.Nov 17 2014, 9:42 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Nov 17 2014, 9:42 PM

Harbormaster completed remote builds in B3072: Diff 26085.Nov 17 2014, 9:42 PM

Closed by commit rPba778cffd744: Don't add "To/Cc" to HTML mail bodies if there's no HTML mail body (authored by epriestley, committed by epriestley). · Explain WhyNov 17 2014, 9:43 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in T6576: HTML bodies are not passed to all emails.Nov 17 2014, 10:11 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

metamta/

replyhandler/

PhabricatorMailReplyHandler.php

6 lines

Diff 26086

View Options

src/applications/metamta/replyhandler/PhabricatorMailReplyHandler.php

Don't add "To/Cc" to HTML mail bodies if there's no HTML mail bodyClosedPublicActions