Page MenuHomePhabricator
Differential D10863

Don't add "To/Cc" to HTML mail bodies if there's no HTML mail body
ClosedPublic
Actions

Authored by epriestley on Nov 17 2014, 9:41 PM.
Tags
None
Referenced Files
F18119585: D10863.id26086.diff
Wed, Aug 13, 10:01 AM
F18110738: D10863.id.diff
Mon, Aug 11, 11:24 PM
F18109786: D10863.id26085.diff
Mon, Aug 11, 3:18 PM
F18104070: D10863.diff
Sun, Aug 10, 9:41 AM
F18100111: D10863.id26085.diff
Sat, Aug 9, 11:07 AM
F18099261: D10863.id26086.diff
Sat, Aug 9, 3:15 AM
F18092348: D10863.diff
Thu, Aug 7, 9:46 AM
F17951627: D10863.id.diff
Fri, Aug 1, 1:32 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
chad
Maniphest Tasks
T6576: HTML bodies are not passed to all emails
Commits
Restricted Diffusion Commit
rPba778cffd744: Don't add "To/Cc" to HTML mail bodies if there's no HTML mail body
Summary

Ref T6576. This avoids generating almost-empty HTML mail bodies for mail which incorrectly has no HTML body.

Test Plan

Generated some mail locally; the specific hook case is a pain for me to hit right now. Will push and dig in if that doesn't fix it.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 26085.Nov 17 2014, 9:41 PM
epriestley retitled this revision from to Don't add "To/Cc" to HTML mail bodies if there's no HTML mail body.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: chad, btrahan.
epriestley added a task: T6576: HTML bodies are not passed to all emails.
Herald added a subscriber: epriestley. · View Herald TranscriptNov 17 2014, 9:41 PM
chad accepted this revision.Nov 17 2014, 9:42 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 17 2014, 9:42 PM
Harbormaster completed remote builds in B3072: Diff 26085.Nov 17 2014, 9:42 PM
Closed by commit rPba778cffd744: Don't add "To/Cc" to HTML mail bodies if there's no HTML mail body (authored by epriestley, committed by epriestley). · Explain WhyNov 17 2014, 9:43 PM
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in T6576: HTML bodies are not passed to all emails.Nov 17 2014, 10:11 PM

Revision Contents
Changeset List

PathSize
src/
applications/
metamta/
replyhandler/
6 lines

Diff 26086

View Options

src/applications/metamta/replyhandler/PhabricatorMailReplyHandler.php

Loading...
Phabricator · Built by Phacility