Ref T2617, adding inline styles to handle html email objects
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Maniphest Tasks
- Restricted Maniphest Task
- Commits
- rPHU9076d7ccdaaa: Process Remarkup in text and HTML email bodies appropriately
Add code block to a Maniphest comment. Email should show pretty yellow background for code block.
Diff Detail
Diff Detail
- Repository
- rPHU libphutil
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Some style nitpicks inline.
| src/markup/engine/remarkup/blockrule/PhutilRemarkupCodeBlockRule.php | ||
|---|---|---|
| 135–145 | Some of these have inconsistent formatting, like this one has a huge indent on the 'style' attribute. This is nitpicky and we should really write lint rules for it, but consider making indentation and layout more consistent with the standard style: $var = array( 'attr' => 'value', ); | |
| src/markup/engine/remarkup/blockrule/PhutilRemarkupNoteBlockRule.php | ||
| 75–76 | For consistency, prefer to write this as: } else if {Instead of: } else
if { | |