Page MenuHomePhabricator
Differential D10856

Config / setup - check for ONLY_FULL_GROUP_BY and warn the user
ClosedPublic
Actions

Authored by btrahan on Nov 15 2014, 2:47 AM.
Tags
None
Referenced Files
F15418593: D10856.id26064.diff
Fri, Mar 21, 12:19 AM
F15416372: D10856.id.diff
Thu, Mar 20, 10:45 AM
F15412085: D10856.diff
Wed, Mar 19, 11:14 AM
F15409772: D10856.diff
Wed, Mar 19, 5:13 AM
F15407156: D10856.id26065.diff
Tue, Mar 18, 4:10 PM
F15368314: D10856.diff
Wed, Mar 12, 1:28 AM
F15367535: D10856.id26064.diff
Tue, Mar 11, 7:07 PM
F15344024: D10856.id.diff
Mon, Mar 10, 2:32 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T6243: Detect MySQL when ONLY_FULL_GROUP_BY is enabled
Commits
Restricted Diffusion Commit
rP4e5775f1dad9: Config / setup - check for ONLY_FULL_GROUP_BY and warn the user
Summary

Fixes T6243.

Test Plan

simulated having this on by adding 'ONLY_FULL_GROUP_BY' to the $modes array. verified the error message looked nice

Screen_Shot_2014-11-14_at_6.45.43_PM.png (1×2 px, 596 KB)
.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

btrahan updated this revision to Diff 26064.Nov 15 2014, 2:47 AM
btrahan added a task: T6243: Detect MySQL when ONLY_FULL_GROUP_BY is enabled.
btrahan retitled this revision from to Config / setup - check for ONLY_FULL_GROUP_BY and warn the user.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptNov 15 2014, 2:47 AM
btrahan added a comment.Nov 15 2014, 2:47 AM

Screen_Shot_2014-11-14_at_6.45.43_PM.png (1×2 px, 596 KB)

btrahan edited the test plan for this revision. (Show Details)Nov 15 2014, 2:47 AM
Harbormaster completed remote builds in B3057: Diff 26064.Nov 15 2014, 2:47 AM
btrahan added a comment.Nov 15 2014, 2:48 AM

Note this screenshot is somewhat nonsense due to my test method... The "your sql mode is set to X" bit in particular doesn't reflect real values that would trip this condition.

epriestley accepted this revision.Nov 15 2014, 2:50 AM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Nov 15 2014, 2:50 AM
Closed by commit rP4e5775f1dad9: Config / setup - check for ONLY_FULL_GROUP_BY and warn the user (authored by btrahan, committed by btrahan). · Explain WhyNov 15 2014, 2:51 AM
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in T13404: Make Phabricator compatible with ONLY_FULL_GROUP_BY.Sep 3 2019, 11:23 PM

Revision Contents
Changeset List

PathSize
src/
applications/
config/
check/
40 lines

Diff 26065

View Options

src/applications/config/check/PhabricatorSetupCheckMySQL.php

Loading...
Phabricator · Built by Phacility