Page MenuHomePhabricator

Config / setup - check for ONLY_FULL_GROUP_BY and warn the user
ClosedPublic

Authored by btrahan on Nov 15 2014, 2:47 AM.

Details

Summary

Fixes T6243.

Test Plan

simulated having this on by adding 'ONLY_FULL_GROUP_BY' to the $modes array. verified the error message looked nice

.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

btrahan updated this revision to Diff 26064.Nov 15 2014, 2:47 AM
btrahan retitled this revision from to Config / setup - check for ONLY_FULL_GROUP_BY and warn the user.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
btrahan edited the test plan for this revision. (Show Details)Nov 15 2014, 2:47 AM

Note this screenshot is somewhat nonsense due to my test method... The "your sql mode is set to X" bit in particular doesn't reflect real values that would trip this condition.

epriestley accepted this revision.Nov 15 2014, 2:50 AM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Nov 15 2014, 2:50 AM
This revision was automatically updated to reflect the committed changes.