Page MenuHomePhabricator

Move directory SQL patch construction to abstract base class
ClosedPublic

Authored by epriestley on Nov 13 2014, 6:34 PM.

Details

Summary

Ref T6238. I'm building the instance management application now, but not putting it in the upstream -- I think the only use case for it is to build SAAS. If someone comes up with a use case (maybe a college course that wants to create an instance per-class or something?) we could open it up eventually, but it seems cleaner to keep it out of the upstream until we have such a use case.

I need to add schema patches. Make it easier for a subclass to just "add all the patches in this directory", like "autopatches/" works.

Test Plan
  • Ran bin/storage status, saw all normal patches still valid.
  • In some future diff, the instances application will use this to apply patches.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley retitled this revision from to Move directory SQL patch construction to abstract base class.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.

Yeah, I don't know if that stuff should ever end up in the upstream... e.g. we should host that college course ourselves.

This revision is now accepted and ready to land.Nov 13 2014, 7:38 PM
epriestley edited edge metadata.
  • Also tighten a typehint in the new timeline stuff.
src/applications/base/controller/PhabricatorController.php
530

This gives a better error message if you forget to implement the interface, like I did in the Instances stuff.

This revision was automatically updated to reflect the committed changes.