Differential D10843

diffusion / differential - better handle case where no comment selected
ClosedPublic
Actions

Authored by btrahan on Nov 12 2014, 8:20 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Dec 30, 9:54 PM

	Unknown Object (File)
	Sat, Dec 28, 11:09 PM

	Unknown Object (File)
	Tue, Dec 24, 4:16 PM

	Unknown Object (File)
	Thu, Dec 19, 4:26 PM

	Unknown Object (File)
	Thu, Dec 19, 4:25 PM

	Unknown Object (File)
	Thu, Dec 19, 4:25 PM

	Unknown Object (File)
	Thu, Dec 19, 4:25 PM

	Unknown Object (File)
	Thu, Dec 19, 1:42 PM

Subscribers

Details

Reviewers

Maniphest Tasks

T6107: "Reply to inline comment" shortcut broken in Diffusion

Commits

Restricted Diffusion Commit
rP22551d106d35: diffusion / differential - better handle case where no comment selected

Summary

Right now, if no comment is selected the JS executes and throws an exception. Instead, if nothing is selected just do nothing. Fixes T6107.

Test Plan

opened up a commit in diffusion with an inline comment. pressed 'r' and saw no exceptions and nothing happen. pressed 'n' to select the next inline comment and then 'r' and it worked. opened up a commit in diffusion without any inline comments. pressed 'r' and saw no exceptions and nothing happen. opened up a diff in differential with an inline comment. pressed 'r' and saw no exceptons and nothing happened. pressed 'n' to select the next inline comment and then 'r' and it worked.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

btrahan updated this revision to Diff 26025.Nov 12 2014, 8:20 PM

btrahan added a task: T6107: "Reply to inline comment" shortcut broken in Diffusion.

btrahan retitled this revision from to diffusion / differential - better handle case where no comment selected.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added a reviewer: epriestley.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptNov 12 2014, 8:20 PM

Harbormaster completed remote builds in B3032: Diff 26025.Nov 12 2014, 8:20 PM

(Map might need regen.)

This revision is now accepted and ready to land.Nov 12 2014, 8:24 PM

./bin/celerity map changes

Harbormaster completed remote builds in B3033: Diff 26026.Nov 12 2014, 8:26 PM

Closed by commit rP22551d106d35: diffusion / differential - better handle case where no comment selected (authored by btrahan, committed by btrahan). · Explain WhyNov 12 2014, 8:26 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

18 lines

webroot/

rsrc/

js/

application/

differential/

behavior-keyboard-nav.js

4 lines

Diff 26027

resources/celerity/map.php

Loading...

webroot/rsrc/js/application/differential/behavior-keyboard-nav.js

Loading...