Page MenuHomePhabricator

diffusion / differential - better handle case where no comment selected
ClosedPublic

Authored by btrahan on Nov 12 2014, 8:20 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 25, 12:58 AM
Unknown Object (File)
Thu, Apr 11, 8:43 AM
Unknown Object (File)
Fri, Mar 29, 7:29 PM
Unknown Object (File)
Fri, Mar 29, 7:29 PM
Unknown Object (File)
Mar 15 2024, 11:54 PM
Unknown Object (File)
Jan 10 2024, 3:50 PM
Unknown Object (File)
Jan 10 2024, 3:50 PM
Unknown Object (File)
Jan 10 2024, 3:50 PM
Subscribers

Details

Summary

Right now, if no comment is selected the JS executes and throws an exception. Instead, if nothing is selected just do nothing. Fixes T6107.

Test Plan

opened up a commit in diffusion with an inline comment. pressed 'r' and saw no exceptions and nothing happen. pressed 'n' to select the next inline comment and then 'r' and it worked. opened up a commit in diffusion without any inline comments. pressed 'r' and saw no exceptions and nothing happen. opened up a diff in differential with an inline comment. pressed 'r' and saw no exceptons and nothing happened. pressed 'n' to select the next inline comment and then 'r' and it worked.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

btrahan retitled this revision from to diffusion / differential - better handle case where no comment selected.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
epriestley edited edge metadata.

(Map might need regen.)

This revision is now accepted and ready to land.Nov 12 2014, 8:24 PM
btrahan edited edge metadata.

./bin/celerity map changes

This revision was automatically updated to reflect the committed changes.