Page MenuHomePhabricator

Separate SSH key management from the settings panel
ClosedPublic

Authored by epriestley on Nov 9 2014, 6:42 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 19, 4:24 PM
Unknown Object (File)
Thu, Dec 19, 4:24 PM
Unknown Object (File)
Thu, Dec 19, 1:41 PM
Unknown Object (File)
Thu, Dec 19, 1:41 PM
Unknown Object (File)
Sun, Dec 8, 11:22 AM
Unknown Object (File)
Fri, Dec 6, 12:37 AM
Unknown Object (File)
Fri, Nov 29, 12:07 PM
Unknown Object (File)
Sun, Nov 24, 3:49 AM
Subscribers

Details

Summary

Ref T5833. I want to add SSH keys to Almanac devices, but the edit workflows for them are currently bound tightly to users.

Instead, decouple key management from users and the settings panel.

Test Plan
  • Uploaded, generated, edited and deleted SSH keys.
  • Hit missing name, missing key, bad key format, duplicate key errors.
  • Edited/generated/deleted/etc keys for a bot user as an administrator.
  • Got HiSec'd on everything.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Separate SSH key management from the settings panel.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Nov 10 2014, 10:00 PM
This revision was automatically updated to reflect the committed changes.