Differential D10818

Phriction - sever remaining project ties
ClosedPublic
Actions

Authored by btrahan on Nov 8 2014, 2:11 AM.

Tags

None

Referenced Files

	F14093719: D10818.diff
	Mon, Nov 25, 12:34 PM

	Unknown Object (File)
	Thu, Nov 21, 3:32 AM

	Unknown Object (File)
	Sun, Nov 17, 12:55 PM

	Unknown Object (File)
	Sat, Nov 16, 10:19 PM

	Unknown Object (File)
	Sat, Oct 26, 9:22 PM

	Unknown Object (File)
	Oct 24 2024, 1:38 AM

	Unknown Object (File)
	Oct 20 2024, 3:49 PM

	Unknown Object (File)
	Oct 14 2024, 5:36 PM

Subscribers

Details

Reviewers

Maniphest Tasks

T6497: PhrictionDocumentQuery still has a project-respecting hunk of code

Commits

Restricted Diffusion Commit
rPb655699a6cfb: Phriction - sever remaining project ties

Summary

'cuz the wiki don't play that no more. Fixes T6497. This is mainly important to fix an incorrect policy filtering issue where a project policy can incorrectly override a document policy. Otherwise, it makes things nice and clean.

Test Plan

viewed the wiki - success.
viewed wiki document list under "index" and tried a few different queries
grep'd for things like "hasProject" and "getProject" and saw no phriction-related results

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

btrahan updated this revision to Diff 25967.Nov 8 2014, 2:11 AM

btrahan added a task: T6497: PhrictionDocumentQuery still has a project-respecting hunk of code .

btrahan retitled this revision from to Phriction - sever remaining project ties.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added a reviewer: epriestley.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptNov 8 2014, 2:11 AM

Harbormaster completed remote builds in B2996: Diff 25967.Nov 8 2014, 2:12 AM

btrahan edited the test plan for this revision. (Show Details)Nov 8 2014, 2:12 AM

Sweet.

This revision is now accepted and ready to land.Nov 8 2014, 3:02 AM

Closed by commit rPb655699a6cfb: Phriction - sever remaining project ties (authored by btrahan, committed by btrahan). · Explain WhyNov 8 2014, 6:34 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

phriction/

query/

PhrictionDocumentQuery.php

32 lines

PhrictionSearchEngine.php

8 lines

storage/

PhrictionDocument.php

14 lines

Diff 25969

src/applications/phriction/query/PhrictionDocumentQuery.php

Loading...

src/applications/phriction/query/PhrictionSearchEngine.php

Loading...

src/applications/phriction/storage/PhrictionDocument.php

Loading...