Page MenuHomePhabricator
Differential D10805

Standardize SSH key storage
ClosedPublic
Actions

Authored by epriestley on Nov 7 2014, 1:12 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 23, 5:36 PM
Unknown Object (File)
Fri, Apr 19, 5:08 PM
Unknown Object (File)
Mon, Apr 15, 4:44 PM
Unknown Object (File)
Thu, Apr 11, 5:55 PM
Unknown Object (File)
Tue, Apr 9, 4:03 PM
Unknown Object (File)
Tue, Apr 9, 1:41 AM
Unknown Object (File)
Sun, Apr 7, 8:39 PM
Unknown Object (File)
Wed, Apr 3, 5:11 PM
View All Files
Subscribers
epriestley
Tokens
"Doubloon" token, awarded by btrahan.

Details

Reviewers
btrahan
Maniphest Tasks
T5833: Build "Almanac", a service/host/device directory
Commits
Restricted Diffusion Commit
rPbf17b12daf43: Standardize SSH key storage
Summary

Ref T5833. This fixes a few weird things with this table:

  • A bunch of columns were nullable for no reason.
  • We stored an MD5 hash of the key (unusual) but never used it and callers were responsible for manually populating it.
  • We didn't perform known-key-text lookups by using an index.
Test Plan
  • Ran migrations.
  • Faked duplicate keys, saw them clean up correctly.
  • Added new keys.
  • Generated new keys.
  • Used bin/auth-ssh and bin/auth-ssh-key.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 25930.Nov 7 2014, 1:12 PM
epriestley retitled this revision from to Standardize SSH key storage.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T5833: Build "Almanac", a service/host/device directory.
Herald added a subscriber: epriestley. · View Herald TranscriptNov 7 2014, 1:12 PM
Harbormaster completed remote builds in B2978: Diff 25930.Nov 7 2014, 1:12 PM
btrahan accepted this revision.Nov 7 2014, 5:01 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Nov 7 2014, 5:01 PM
btrahan awarded a token.Nov 7 2014, 5:01 PM
Closed by commit rPbf17b12daf43: Standardize SSH key storage (authored by epriestley, committed by epriestley). · Explain WhyNov 7 2014, 11:34 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 25961

View Options

resources/sql/autopatches/20141107.ssh.1.colname.sql

Loading...
View Options

resources/sql/autopatches/20141107.ssh.2.keyhash.sql

Loading...
View Options

resources/sql/autopatches/20141107.ssh.3.keyindex.sql

Loading...
View Options

resources/sql/autopatches/20141107.ssh.4.keymig.php

Loading...
View Options

resources/sql/autopatches/20141107.ssh.5.indexnull.sql

Loading...
View Options

resources/sql/autopatches/20141107.ssh.6.indexkey.sql

Loading...
View Options

resources/sql/autopatches/20141107.ssh.7.colnull.sql

Loading...
View Options

scripts/ssh/ssh-auth.php

Loading...
View Options

src/applications/auth/query/PhabricatorAuthSSHKeyQuery.php

Loading...
View Options

src/applications/auth/storage/PhabricatorAuthSSHKey.php

Loading...
View Options

src/applications/auth/storage/PhabricatorAuthSSHPublicKey.php

Loading...
View Options

src/applications/people/storage/PhabricatorUser.php

Loading...
View Options

src/applications/settings/panel/PhabricatorSettingsPanelSSHKeys.php

Loading...
Phabricator · Built by Phacility