Page MenuHomePhabricator
Differential D10800

Apply storage adjustments as part of storage upgrade
ClosedPublic
Actions

Authored by epriestley on Nov 6 2014, 9:56 PM.
Tags
None
Referenced Files
F20738063: D10800.id.diff
Tue, Jun 23, 9:41 AM
F20734015: D10800.diff
Tue, Jun 23, 6:19 AM
Unknown Object (File)
Mon, Jun 22, 7:18 PM
Unknown Object (File)
Sun, Jun 21, 7:13 AM
Unknown Object (File)
Sun, Jun 14, 1:08 AM
Unknown Object (File)
Apr 16 2026, 4:33 PM
Unknown Object (File)
Apr 16 2026, 4:32 PM
Unknown Object (File)
Mar 28 2026, 11:11 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T1191: Comments are truncated at first non-base-plane character
Commits
Restricted Diffusion Commit
rPa17a36869254: Apply storage adjustments as part of storage upgrade
Summary

Fixes T1191. I'll write up the changelog with notes about this and open a feedback task for followups.

When you run storage upgrade, automatically run storage adjust afterward. Provide a flag to disable this.

This brings everyone into the utf8mb4 world.

Test Plan

Ran bin/storage upgrade with various flags. Ran bin/storage adjust.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 25919.Nov 6 2014, 9:56 PM
epriestley retitled this revision from to Apply storage adjustments as part of storage upgrade.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T1191: Comments are truncated at first non-base-plane character.
Herald added a subscriber: epriestley. · View Herald TranscriptNov 6 2014, 9:56 PM
Harbormaster completed remote builds in B2971: Diff 25919.Nov 6 2014, 9:57 PM
epriestley updated this revision to Diff 25920.Nov 6 2014, 9:57 PM
  • Make --dryrun win when run as adjust --force --dryrun.
Harbormaster completed remote builds in B2972: Diff 25920.Nov 6 2014, 9:58 PM
epriestley mentioned this in T1191: Comments are truncated at first non-base-plane character.Nov 6 2014, 10:18 PM
btrahan mentioned this in T6350: Diffusion spamming the feed/commits going weird.Nov 6 2014, 10:25 PM
epriestley mentioned this in T6487: Historic Phriction documents do not have mailKeys populated.Nov 7 2014, 12:00 PM
btrahan accepted this revision.Nov 7 2014, 4:54 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Nov 7 2014, 4:54 PM
Closed by commit rPa17a36869254: Apply storage adjustments as part of storage upgrade (authored by epriestley, committed by epriestley). · Explain WhyNov 7 2014, 10:25 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 25959

View Options

src/infrastructure/storage/management/workflow/PhabricatorStorageManagementAdjustWorkflow.php

Loading...
View Options

src/infrastructure/storage/management/workflow/PhabricatorStorageManagementUpgradeWorkflow.php

Loading...
View Options

src/infrastructure/storage/management/workflow/PhabricatorStorageManagementWorkflow.php

Loading...
Phabricator · Built by Phacility